Subject: Re: [PATCH net-next] ixgbe: flush when in xmit_more mode and under descriptor pressure

From: Alexander Duyck <[email-masked]>
Date: Tue, 26 Aug 2014 09:24:16 -0700

On 08/26/2014 09:21 AM, Daniel Borkmann wrote:
> On 08/26/2014 06:01 PM, Alexander Duyck wrote:
> ...
>> My thought is to just fold ixgbe_maybe_stop_tx into the if statement.
>>
>> So it shoudl be:
>>   if (!skb->smit_more || ixgbe_maybe_stop_tx(tx_ring, DESC_NEEDED))
> 
> Right, that's better; I was just thinking about the DMA error case,
> but in that case we release resources back anyway.

Actually the order does need to be reversed though.  We should test for
stop_tx first, then xmit_more.  Doing it the other way around would
cause issues as maybe_stop_tx has some other side effects.

Thaks,

Alex