Subject: Re: [PATCH v2 net-next] ixgbe: flush when in xmit_more mode and under descriptor pressure

From: Daniel Borkmann <[email-masked]>
Date: Thu, 28 Aug 2014 13:46:09 +0200

On 08/28/2014 08:18 AM, David Miller wrote:
> From: Daniel Borkmann <[email-masked]>
> Date: Tue, 26 Aug 2014 19:34:18 +0200
>
>> When xmit_more mode is being used and the ring is about to
>> become full or the stack has stopped the ring, enforce a tail
>> pointer write to the hw. Otherwise, we could risk a TX hang.
>>
>> Code suggested by Alexander Duyck.
>>
>> Signed-off-by: Alexander Duyck <[email-masked]>
>> Signed-off-by: Daniel Borkmann <[email-masked]>
>> ---
>>   v1->v2:
>>    - Worked in Alex' feedback; in accordance w/ Alex, sending out v2
>>    - Rerun tests, looks good
>
> Applied, thanks Daniel.
>
> I'll make similar mods to igb and vhost_net soon.

Cool, at some point later, we might want to put ...

   netif_xmit_stopped(<tx_ring>) || !skb->xmit_more

... into an API perhaps, but that can likely wait right now.