From: Oliver Hartkopp <socketcan@hartkopp•net>
To: Vadim Kochan <vadim4j@gmail•com>, netdev@vger•kernel.org
Cc: Mehdi Abaakouk <sileht@sileht•net>
Subject: Re: [PATCH] ip link: Remove unnecessary device checking
Date: Sat, 30 Aug 2014 19:01:11 +0200 [thread overview]
Message-ID: <54020357.2030301@hartkopp.net> (raw)
In-Reply-To: <1409400360-31612-1-git-send-email-vadim4j@gmail.com>
On 30.08.2014 14:06, Vadim Kochan wrote:
> The real checking is performed later in iplink_modify(..) func which
> checks device existence if NLM_F_CREATE flag is set.
>
> Also it fixes the case when impossible to add veth link which was
> caused by 9a02651a87 (ip: check for missing dev arg when doing VF rate)
> because these devices are not exist yet.
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail•com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp•net>
This also fixes this issue from Mehdi Abaakouk here:
http://marc.info/?l=linux-netdev&m=140912053421637
And the stuff I needed to change here:
https://gitorious.org/linux-can/can-tests/commit/578d07b0a13e0c171801cde8c048ac657373491e
Thanks for figuring out the detailed problem Vadim!
Regards,
Oliver
> ---
> ip/iplink.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/ip/iplink.c b/ip/iplink.c
> index 1a907d9..ea06871 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -593,8 +593,6 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req,
> duparg2("dev", *argv);
> *dev = *argv;
> dev_index = ll_name_to_index(*dev);
> - if (dev_index == 0)
> - invarg("Unknown device", *argv);
> }
> argc--; argv++;
> }
>
prev parent reply other threads:[~2014-08-30 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 12:06 [PATCH] ip link: Remove unnecessary device checking Vadim Kochan
2014-08-30 17:01 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54020357.2030301@hartkopp.net \
--to=socketcan@hartkopp$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sileht@sileht$(echo .)net \
--cc=vadim4j@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox