From: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux•com>
To: Ian Morris <ipm@chirality•org.uk>, netdev@vger•kernel.org
Cc: hideaki.yoshifuji@miraclelinux•com,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
Subject: Re: [PATCH net-next 2/4] ipv6: coding style - min to min_t conversion
Date: Wed, 03 Sep 2014 10:29:30 +0900 [thread overview]
Message-ID: <54066EFA.7090400@miraclelinux.com> (raw)
In-Reply-To: <1409685364-4327-3-git-send-email-ipm@chirality.org.uk>
Hi,
Ian Morris wrote:
> This patch changes a min to min_t as per checkpatch recomendation.
>
> No change in the object output is detected by the objdiff script.
>
> Signed-off-by: Ian Morris <ipm@chirality•org.uk>
> ---
> net/ipv6/addrconf.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 509c53e..23d8493 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2320,8 +2320,11 @@ ok:
> else
> stored_lft = 0;
> if (!update_lft && !create && stored_lft) {
> - const u32 minimum_lft = min(
> - stored_lft, (u32)MIN_VALID_LIFETIME);
> + const u32 minimum_lft = min_t(
> + u32,
> + stored_lft,
> + MIN_VALID_LIFETIME);
> +
> valid_lft = max(valid_lft, minimum_lft);
>
> /* RFC4862 Section 5.5.3e:
>
Please put 1st argument(u32) at the first line and make arguments aligned.
--
Hideaki Yoshifuji <hideaki.yoshifuji@miraclelinux•com>
Technical Division, MIRACLE LINUX CORPORATION
next prev parent reply other threads:[~2014-09-03 1:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 19:16 [PATCH net-next 0/4] ipv6: coding style improvements Ian Morris
2014-09-02 19:16 ` [PATCH net-next 1/4] ipv6: coding style - no assignment in if statements Ian Morris
2014-09-03 1:44 ` YOSHIFUJI Hideaki
2014-09-02 19:16 ` [PATCH net-next 2/4] ipv6: coding style - min to min_t conversion Ian Morris
2014-09-03 1:29 ` YOSHIFUJI Hideaki [this message]
2014-09-02 19:16 ` [PATCH net-next 3/4] ipv6: coding style - convert printk Ian Morris
2014-09-03 1:44 ` YOSHIFUJI Hideaki
2014-09-02 19:16 ` [PATCH net-next 4/4] ipv6: coding style - cleanse bracing Ian Morris
2014-09-03 1:31 ` YOSHIFUJI Hideaki/吉藤英明
2014-09-03 7:52 ` Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54066EFA.7090400@miraclelinux.com \
--to=hideaki.yoshifuji@miraclelinux$(echo .)com \
--cc=ipm@chirality$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox