Subject: Re: [PATCH] ip monitor: Dont print timestamp or banner-label for cloned routes

From: Sergei Shtylyov <[email-masked]>
Date: Thu, 04 Sep 2014 23:29:35 +0400

Hello.

On 09/04/2014 10:52 PM, Vadim Kochan wrote:

> This is ugly fix but solves the case when timestamp
> or banner-label is printed before the cloned route will be skipped
> by iproute filter which filters out all cached routes by default.
> In such case timestamp will be printed twice:

>      Timestamp: Thu Sep  4 19:46:59 2014 457933 usec
>      Timestamp: Thu Sep  4 19:47:07 2014 977970 usec
>      10.3.5.1 dev wlp3s0 lladdr XX:XX:XX:XX:XX:XX STALE

> Signed-off-by: Vadim Kochan <[email-masked]>
> ---
>   ip/ipmonitor.c | 13 ++++++++++---
>   1 file changed, 10 insertions(+), 3 deletions(-)

> diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c
> index 70f2a7a..2bd3fed 100644
> --- a/ip/ipmonitor.c
> +++ b/ip/ipmonitor.c
[...]
> @@ -53,6 +50,12 @@ static int accept_msg(const struct sockaddr_nl *who,
>   			return -1;
>   		}
>
> +		if (r->rtm_flags&RTM_F_CLONED)

    Judging on the patched code, spaces are needed around &.

> +			return 0;
> +
> +		if (timestamp)
> +			print_timestamp(fp);
> +
>   		if (r->rtm_family == RTNL_FAMILY_IPMR ||
>   		    r->rtm_family == RTNL_FAMILY_IP6MR) {
>   			if (prefix_banner)
[...]

WBR, Sergei