From: Vlad Yasevich <vyasevic@redhat•com>
To: Alexei Starovoitov <alexei.starovoitov@gmail•com>,
Vlad Yasevich <vyasevich@gmail•com>
Cc: Jiri Pirko <jiri@resnulli•us>,
netdev@vger•kernel.org, Florian Zumbiehl <florz@florz•de>,
Eric Dumazet <eric.dumazet@gmail•com>,
Matthew Rosato <mjrosato@linux•vnet.ibm.com>
Subject: Re: [PATCH net] core: Untag packets after rx_handler has run.
Date: Thu, 04 Sep 2014 17:01:12 -0400 [thread overview]
Message-ID: <5408D318.4020009@redhat.com> (raw)
In-Reply-To: <20140904204314.GA16612@its-macbook-pro.plumgrid.com>
On 09/04/2014 04:43 PM, Alexei Starovoitov wrote:
> On Thu, Sep 04, 2014 at 03:29:00PM -0400, Vlad Yasevich wrote:
>>> nack. This will definitelly break several stacked setups.
>>
>> Which ones? The only thing I can see that would behave differently
>> is something like:
>>
>> vlan0 bridge0
>> | |
>> +-------- eth0
>>
>> In this case, the old code would give an untagged packet to the bridge
>> and the new code would give a tagged packet.
>>
>> This set-up is a bit ambiguous. Remove the vlan, and bridge gets a tagged
>> traffic even though the vlan has no relationship to the bridge.
>>
>> I've tested a couple of different stacked setups and they all seem to work.
>
> 2nd nack.
> It will break user space, including our setup that has:
> vlanX OVS
> | |
> +------ eth0
>
> vlan device has IP assigned and all tagged traffic goes through the stack
> and into control plane process. ovs datapath keeps managing eth0 with
> all other vlans.
>
Did you specially configure OVS to pass the traffic up the stack? I see
OVS will only pass LOOPBACK packets. All others it seems to consume.
Can the same be accomplished with a tagged internal port?
The reason I am asking, is I am trying to figure out if this is
a valid config. It seems very hard to get right and seems to work almost
by accident at times. For example, in the bridge scenario I described.
vlan and bridge have to share a mac address for that work.
-vlad
next prev parent reply other threads:[~2014-09-04 21:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 18:40 [PATCH net] core: Untag packets after rx_handler has run Vladislav Yasevich
2014-09-04 19:05 ` Jiri Pirko
2014-09-04 19:29 ` Vlad Yasevich
2014-09-04 20:43 ` Alexei Starovoitov
2014-09-04 21:01 ` Vlad Yasevich [this message]
2014-09-04 21:54 ` Alexei Starovoitov
2014-09-04 23:48 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408D318.4020009@redhat.com \
--to=vyasevic@redhat$(echo .)com \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=florz@florz$(echo .)de \
--cc=jiri@resnulli$(echo .)us \
--cc=mjrosato@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox