From: Nikolay Aleksandrov <nikolay@redhat•com>
To: Jiri Pirko <jiri@resnulli•us>, netdev@vger•kernel.org
Cc: davem@davemloft•net, j.vosburgh@gmail•com, vfalico@gmail•com,
andy@greyhouse•net
Subject: Re: [patch net-next] bonding: add slave netlink policy and put slave-related ops together
Date: Fri, 05 Sep 2014 12:21:06 +0200 [thread overview]
Message-ID: <54098E92.6020207@redhat.com> (raw)
In-Reply-To: <1409909794-7664-1-git-send-email-jiri@resnulli.us>
On 05/09/14 11:36, Jiri Pirko wrote:
> Signed-off-by: Jiri Pirko <jiri@resnulli•us>
> ---
> drivers/net/bonding/bond_netlink.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
> index 1570dea..e1489d9 100644
> --- a/drivers/net/bonding/bond_netlink.c
> +++ b/drivers/net/bonding/bond_netlink.c
> @@ -96,6 +96,10 @@ static const struct nla_policy bond_policy[IFLA_BOND_MAX + 1] = {
> [IFLA_BOND_AD_INFO] = { .type = NLA_NESTED },
> };
>
> +static const struct nla_policy bond_slave_policy[IFLA_BOND_SLAVE_MAX + 1] = {
> + [IFLA_BOND_SLAVE_QUEUE_ID] = { .type = NLA_U16 },
> +};
> +
> static int bond_validate(struct nlattr *tb[], struct nlattr *data[])
> {
> if (tb[IFLA_ADDRESS]) {
> @@ -580,17 +584,18 @@ struct rtnl_link_ops bond_link_ops __read_mostly = {
> .priv_size = sizeof(struct bonding),
> .setup = bond_setup,
> .maxtype = IFLA_BOND_MAX,
> - .slave_maxtype = IFLA_BOND_SLAVE_MAX,
> .policy = bond_policy,
> .validate = bond_validate,
> .newlink = bond_newlink,
> .changelink = bond_changelink,
> - .slave_changelink = bond_slave_changelink,
> .get_size = bond_get_size,
> .fill_info = bond_fill_info,
> .get_num_tx_queues = bond_get_num_tx_queues,
> .get_num_rx_queues = bond_get_num_tx_queues, /* Use the same number
> as for TX queues */
> + .slave_maxtype = IFLA_BOND_SLAVE_MAX,
> + .slave_policy = bond_slave_policy,
> + .slave_changelink = bond_slave_changelink,
> .get_slave_size = bond_get_slave_size,
> .fill_slave_info = bond_fill_slave_info,
> };
>
Right, the validation policy, I knew I forgot something :-)
Acked-by: Nikolay Aleksandrov <nikolay@redhat•com>
next prev parent reply other threads:[~2014-09-05 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 9:36 [patch net-next] bonding: add slave netlink policy and put slave-related ops together Jiri Pirko
2014-09-05 10:21 ` Nikolay Aleksandrov [this message]
2014-09-06 4:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54098E92.6020207@redhat.com \
--to=nikolay@redhat$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vfalico@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox