Subject: Re: [PATCH net-next] bonding: limit primary_reselect to modes that use primary only

From: Nikolay Aleksandrov <[email-masked]>
Date: Fri, 05 Sep 2014 14:17:36 +0200

On 05/09/14 14:13, Nikolay Aleksandrov wrote:
> Signed-off-by: Nikolay Aleksandrov <[email-masked]>
> ---
>   drivers/net/bonding/bond_options.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
> index d8dc17faa6b4..591c1fbb7c8d 100644
> --- a/drivers/net/bonding/bond_options.c
> +++ b/drivers/net/bonding/bond_options.c
> @@ -316,6 +316,9 @@ static const struct bond_option bond_opts[] = {
>   		.id = BOND_OPT_PRIMARY_RESELECT,
>   		.name = "primary_reselect",
>   		.desc = "Reselect primary slave once it comes up",
> +		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
> +						BIT(BOND_MODE_TLB) |
> +						BIT(BOND_MODE_ALB)),
>   		.values = bond_primary_reselect_tbl,
>   		.set = bond_option_primary_reselect_set
>   	},
>

Actually, self-nak as this adds option dependency.
Sorry for the noise

Nik