Subject: Re: [PATCH net-next 1/3] net: Add function for parsing the header length out of linear ethernet frames

From: Alexander Duyck <[email-masked]>
Date: Fri, 05 Sep 2014 16:15:10 -0700

On 09/05/2014 01:02 PM, Alexei Starovoitov wrote:
> On Fri, Sep 5, 2014 at 11:10 AM, Alexander Duyck
> <[email-masked]> wrote:
>> This patch updates some of the flow_dissector api so that it can be used to
>> parse the length of ethernet buffers stored in fragments.  Most of the
>> changes needed were to __skb_get_poff as it needed to be updated to support
>> sending a linear buffer instead of a skb.
>>
>>
>>  u32 __skb_get_poff(const struct sk_buff *skb);
>> +u32 ___skb_get_poff(const struct sk_buff *skb, void *data,
>> +                   const struct flow_keys *keys, int hlen);
> 
> three underscores and not a static function?
> May be we need to come with a proper name for it.
> Two easy to confuse with two underscore version...

Actually what I could do is probably rename the 2 underscore version to
drop the underscores and then rename the 3 underscore version to just 2
underscores.  Then it would match up closer with how the other functions
are dealing with the data/hlen values.

Thanks,

Alex