Subject: Re: [net-next PATCH v3 05/15] net: sched: cls_flow use RCU

From: John Fastabend <[email-masked]>
Date: Tue, 09 Sep 2014 09:09:36 -0700

On 09/09/2014 05:41 AM, Eric Dumazet wrote:
> On Mon, 2014-09-08 at 22:56 -0700, John Fastabend wrote:
>> Signed-off-by: John Fastabend <[email-masked]>
>> ---
>>   net/sched/cls_flow.c |  145 +++++++++++++++++++++++++++++---------------------
>>   1 file changed, 84 insertions(+), 61 deletions(-)
>>
>> diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c
>> index 35be16f..e33560b 100644
>> --- a/net/sched/cls_flow.c
>> +++ b/net/sched/cls_flow.c
>> @@ -34,12 +34,15 @@
>>
>>   struct flow_head {
>>   	struct list_head	filters;
>> +	struct rcu_head		rcu;
>>   };
>>
>>   struct flow_filter {
>>   	struct list_head	list;
>> +	struct rcu_head		rcu;
>
> Please move these 2 new fields at the end of structure, they are only
> used at dismantle phase.
>
> Patch looks fine otherwise, thanks !
>
>

2 new fields? The first rcu struct is already at end of
structure. I assume you just mean the rcu struct in flow_filter.

.John

-- 
John Fastabend         Intel Corporation