From: Florian Fainelli <f.fainelli@gmail•com>
To: Mike Looijmans <mike.looijmans@topic•nl>, netdev@vger•kernel.org
Cc: linux-kernel@vger•kernel.org
Subject: Re: [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031
Date: Thu, 11 Sep 2014 11:41:45 -0700 [thread overview]
Message-ID: <5411ECE9.8050600@gmail.com> (raw)
In-Reply-To: <1410443140-2833-1-git-send-email-mike.looijmans@topic.nl>
On 09/11/2014 06:45 AM, Mike Looijmans wrote:
> Our KSZ9031 appears to suffer from the same hardware bug as described
> for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577,
> you have to unplug the cable and plug it back to get it to work.
>
> Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this.
Can you resend this patch specifying the commit subject in parenthesis
like this:
commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577 ("net/phy: micrel:
Disable asymmetric pause for KSZ9021")
since this is a bugfix, it should probably be targeting the 'net' tree,
rather than the 'net-next' tree, though the patch applies to both cleanly.
Other than that:
Acked-by: Florian Fainelli <f.fainelli@gmail•com>
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic•nl>
> ---
> drivers/net/phy/micrel.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 5a8993b..a932a35 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -425,8 +425,7 @@ static struct phy_driver ksphy_driver[] = {
> .phy_id = PHY_ID_KSZ9031,
> .phy_id_mask = 0x00fffff0,
> .name = "Micrel KSZ9031 Gigabit PHY",
> - .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause
> - | SUPPORTED_Asym_Pause),
> + .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause),
> .flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
> .config_init = kszphy_config_init,
> .config_aneg = genphy_config_aneg,
>
next prev parent reply other threads:[~2014-09-11 18:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 13:45 [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031 Mike Looijmans
2014-09-11 18:41 ` Florian Fainelli [this message]
2014-09-12 6:54 ` Mike Looijmans
2014-09-12 12:40 ` [PATCH v2] " Mike Looijmans
2014-09-12 22:18 ` David Miller
2014-09-15 7:44 ` Mike Looijmans
2014-09-15 10:06 ` [PATCH v3] " Mike Looijmans
2014-09-15 10:07 ` Mike Looijmans
2014-09-15 18:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5411ECE9.8050600@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mike.looijmans@topic$(echo .)nl \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox