Subject: Re: [PATCH net-next v2] net: filter: constify detection of pkt_type_offset

From: Daniel Borkmann <[email-masked]>
Date: Fri, 12 Sep 2014 22:48:17 +0200

On 09/12/2014 02:04 PM, Hannes Frederic Sowa wrote:
> Currently we have 2 pkt_type_offset functions doing the same thing and
> spread across the architecture files. Remove those and replace them
> with a PKT_TYPE_OFFSET macro helper which gets the constant value from a
> zero sized sk_buff member right in front of the bitfield with offsetof.
> This new offset marker does not change size of struct sk_buff.
>
> Cc: Eric Dumazet <[email-masked]>
> Cc: Markos Chandras <[email-masked]>
> Cc: Martin Schwidefsky <[email-masked]>
> Cc: Daniel Borkmann <[email-masked]>
> Cc: Alexei Starovoitov <[email-masked]>
> Signed-off-by: Denis Kirjanov <[email-masked]>
> Signed-off-by: Hannes Frederic Sowa <[email-masked]>

Looks good to me, thanks!

Acked-by: Daniel Borkmann <[email-masked]>