From: John Fastabend <john.r.fastabend@intel•com>
To: Cong Wang <xiyou.wangcong@gmail•com>, netdev@vger•kernel.org
Cc: john.fastabend@gmail•com, "David S. Miller" <davem@davemloft•net>
Subject: Re: [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf_classify()
Date: Mon, 15 Sep 2014 14:30:19 -0700 [thread overview]
Message-ID: <54175A6B.90602@intel.com> (raw)
In-Reply-To: <1410816110-10354-1-git-send-email-xiyou.wangcong@gmail.com>
On 09/15/2014 02:21 PM, Cong Wang wrote:
> Fixes: commit 1f947bf151e90ec0baad2948 ("net: sched: rcu'ify cls_bpf")
> Cc: John Fastabend <john.fastabend@gmail•com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail•com>
> ---
> net/sched/cls_bpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
> index 6a7386e..4e3f5bf 100644
> --- a/net/sched/cls_bpf.c
> +++ b/net/sched/cls_bpf.c
> @@ -52,7 +52,7 @@ static const struct nla_policy bpf_policy[TCA_BPF_MAX + 1] = {
> static int cls_bpf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
> struct tcf_result *res)
> {
> - struct cls_bpf_head *head = rcu_dereference(tp->root);
> + struct cls_bpf_head *head = rcu_dereference_bh(tp->root);
> struct cls_bpf_prog *prog;
> int ret;
>
>
you beat me to it.
Acked-by: John Fastabend <john.r.fastabend@intel•com>
next prev parent reply other threads:[~2014-09-15 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 21:21 [Patch net-next] net_sched: fix suspicious RCU usage in cls_bpf_classify() Cong Wang
2014-09-15 21:30 ` John Fastabend [this message]
2014-09-15 21:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54175A6B.90602@intel.com \
--to=john.r.fastabend@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox