Subject: Re: [PATCH] bridge: Fix br_should_learn to check vlan_enabled

From: Toshiaki Makita <[email-masked]>
Date: Tue, 16 Sep 2014 19:40:43 +0900

On 2014/09/16 6:38, David Miller wrote:
> From: Vladislav Yasevich <[email-masked]>
> Date: Mon, 15 Sep 2014 15:24:26 -0400
> 
>> As Toshiaki Makita pointed out, the BRIDGE_INPUT_SKB_CB will
>> not be initialized in br_should_learn() as that function
>> is called only from br_handle_local_finish().  That is
>> an input handler for link-local ethernet traffic so it perfectly
>> correct to check br->vlan_enabled here.
>>
>> Reported-by: Toshiaki Makita<[email-masked]>
>> Fixes: 20adfa1 bridge: Check if vlan filtering is enabled only once.
>> Signed-off-by: Vladislav Yasevich <[email-masked]>
> 
> Applied, thanks Vlad.

Hi David,

Could you queue this for -stable as well?
Without this, FDB can be poisoned by disallowed ports.
(the same problem as stated in e0d7968ab6c8 "bridge: Prevent insertion
of FDB entry with disallowed vlan")

Thanks,
Toshiaki Makita