From: Doug Ledford <dledford@xsintricity•com>
To: Eric Dumazet <eric.dumazet@gmail•com>, Or Gerlitz <or.gerlitz@gmail•com>
Cc: Govindarajulu Varadarajan <_govind@gmx•com>,
Yinghai Lu <yinghai@kernel•org>,
David Miller <davem@davemloft•net>,
NetDev <netdev@vger•kernel.org>,
ssujith@cisco•com, gvaradar@cisco•com,
"Christian Benvenuti (benve)" <benve@cisco•com>
Subject: Re: [net] net: sched: shrink struct qdisc_skb_cb to 28 bytes
Date: Thu, 18 Sep 2014 18:29:31 -0400 [thread overview]
Message-ID: <541B5CCB.6060808@xsintricity.com> (raw)
In-Reply-To: <1411052525.7106.269.camel@edumazet-glaptop2.roam.corp.google.com>
On 09/18/2014 11:02 AM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> We cannot make struct qdisc_skb_cb bigger without impacting IPoIB,
> or increasing skb->cb[] size.
>
> Commit e0f31d849867 ("flow_keys: Record IP layer protocol in
> skb_flow_dissect()") broke IPoIB.
>
> Only current offender is sch_choke, and this one do not need an
> absolutely precise flow key.
>
> If we store 17 bytes of flow key, its more than enough. (Its the actual
> size of flow_keys if it was a packed structure, but we might add new
> fields at the end of it later)
>
> Signed-off-by: Eric Dumazet <edumazet@google•com>
> Fixes: e0f31d849867 ("flow_keys: Record IP layer protocol in skb_flow_dissect()")
I've installed this patch on my cluster and it resolves the problem.
Tested-by/Acked-by: Doug Ledford <dledford@redhat•com>
next prev parent reply other threads:[~2014-09-18 22:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 18:32 [PATCH net-next 0/8] enic updates Govindarajulu Varadarajan
2014-06-09 18:32 ` [PATCH net-next 1/8] flow_keys: Record IP layer protocol in skb_flow_dissect() Govindarajulu Varadarajan
2014-06-10 13:11 ` Daniel Borkmann
2014-06-10 14:08 ` Govindarajulu Varadarajan
2014-06-10 14:26 ` Eric Dumazet
2014-06-11 22:06 ` David Miller
2014-06-11 22:08 ` David Miller
2014-06-12 5:38 ` Govindarajulu Varadarajan
2014-06-19 18:06 ` Chema Gonzalez
2014-06-19 18:52 ` Govindarajulu Varadarajan
2014-06-24 5:29 ` Yinghai Lu
2014-06-26 6:34 ` Govindarajulu Varadarajan
2014-09-18 14:18 ` Or Gerlitz
2014-09-18 14:38 ` Eric Dumazet
2014-09-18 15:02 ` [PATCH net] net: sched: shrink struct qdisc_skb_cb to 28 bytes Eric Dumazet
2014-09-18 16:26 ` Stephen Hemminger
2014-09-18 16:32 ` Eric Dumazet
2014-09-18 18:00 ` Eric Dumazet
2014-09-18 18:07 ` Joe Perches
2014-09-18 19:14 ` Eric Dumazet
2014-09-18 19:31 ` Joe Perches
2014-09-18 20:31 ` Eric Dumazet
2014-09-18 21:28 ` Or Gerlitz
2014-09-18 22:29 ` Doug Ledford [this message]
2014-09-19 12:07 ` [net] " Or Gerlitz
2014-09-22 18:38 ` David Miller
2014-09-22 18:22 ` [PATCH net] " David Miller
2014-06-09 18:32 ` [PATCH net-next 2/8] enic: fix return value in _vnic_dev_cmd Govindarajulu Varadarajan
2014-06-09 18:32 ` [PATCH net-next 3/8] enic: devcmd for adding IP 5 tuple hardware filters Govindarajulu Varadarajan
2014-06-09 18:32 ` [PATCH net-next 4/8] enic: alloc/free rx_cpu_rmap Govindarajulu Varadarajan
2014-06-09 18:44 ` Sergei Shtylyov
2014-06-10 13:52 ` Govindarajulu Varadarajan
2014-06-10 15:00 ` Sergei Shtylyov
2014-06-09 18:32 ` [PATCH net-next 5/8] enic: Add Accelerated RFS support Govindarajulu Varadarajan
2014-06-09 18:32 ` [PATCH net-next 6/8] enic: fix lockdep around devcmd_lock Govindarajulu Varadarajan
2014-06-09 18:32 ` [PATCH net-next 7/8] enic: add low latency socket busy_poll support Govindarajulu Varadarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B5CCB.6060808@xsintricity.com \
--to=dledford@xsintricity$(echo .)com \
--cc=_govind@gmx$(echo .)com \
--cc=benve@cisco$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=gvaradar@cisco$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=or.gerlitz@gmail$(echo .)com \
--cc=ssujith@cisco$(echo .)com \
--cc=yinghai@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox