Subject: Re: [net-next PATCH 29/29] fm10k: Add support for PTP

From: Alexander Duyck <[email-masked]>
Date: Mon, 22 Sep 2014 07:21:38 -0700

On 09/22/2014 04:03 AM, David Laight wrote:
> From: Of Richard Cochran
>> On Thu, Sep 18, 2014 at 06:40:46PM -0400, Alexander Duyck wrote:
>>
>>> +static s32 fm10k_1588_msg_vf(struct fm10k_hw *hw, u32 **results,
>>> +			     struct fm10k_mbx_info *mbx)
>>> +{
>>> +	struct fm10k_intfc *interface = container_of(hw,
>>> +						     struct fm10k_intfc,
>>> +						     hw);
>>
>> This looks really funny to me here and in the other spot. Why not this?
>>
>> 	struct fm10k_intfc *interface = container_of(hw, struct fm10k_intfc, hw);
>>
>> Its only one over the 80 km/h speed limit.
> 
> Or split the assignment from the declaration.
> 
> 	David

That was the solution I went with.  It solved both the line over 80
characters and breaking up of the container_of parameter list.

Thanks,

Alex