From: David L Stevens <david.stevens@oracle•com>
To: David Miller <davem@davemloft•net>
Cc: Raghuram.Kothakota@oracle•com, netdev@vger•kernel.org
Subject: Re: [PATCHv6 net-next 1/3] sunvnet: upgrade to VIO protocol version 1.6
Date: Tue, 23 Sep 2014 12:49:27 -0400 [thread overview]
Message-ID: <5421A497.9060903@oracle.com> (raw)
In-Reply-To: <20140923.122420.1216927815526255624.davem@davemloft.net>
On 09/23/2014 12:24 PM, David Miller wrote:
> From: David L Stevens <david.stevens@oracle•com>
> Date: Thu, 18 Sep 2014 09:03:52 -0400
>
>> So, if this is actually too much memory, I was more inclined to reduce the ring
>> size rather than either add complicating code to handle active-ring reallocation
>> that would typically be run once per boot, or another alternative of adding
>> module parameters to specify the buffer size TSO/GSO will need 64K to perform
>> well, regardless of the device MTU.
>
> The only reason we are having this discussion is because of how we
> handle TX packets.
>
> I think we really should directly map the SKBs in vnet_start_xmit()
> instead of having these preallocate TX buffers.
>
> The only thing to accomodate is the VNET_PACKET_SKIP, but that
> shouldn't be hard at all.
>
> And I am rather certain that an LDC map call will be cheaper than
> copying the entire packet.
>
> Then the MTU will have no material impact on per-vnet_port memory
> costs, and bulk sending performance should also increase.
>
Actually, that's exactly what I've been working on for the last few
days. I hope to post this soon. Currently, I allow for misaligned
packets by reallocating the skbs with the proper alignment, skip and
length restrictions, so the code can handle either, but still copies
most of the time. Once I have all the kinks worked out there, I was
planning to possibly make *all* skb allocations on LDOMs and/or SPARC64 fit
those requirements, since they are compatible with the existing alignments
and would allow using the HV copy in any case.
> David I know you've worked hard on this patch set, but I'm going to
> defer on this series for now. There are several implementation level
> issues that are still seemingly up in the air.
Yes, sorry if it wasn't clear in my response to Raghuram, but I
agree to the extent that we shouldn't attach large-buffer allocations to
something scaling at O(n^2), which is why I started on this other patch.
> I'm almost completely sold on your PMTU scheme, however if we do
> direct mapping of SKBs in vnet_start_xmit() then the performance
> characteristics with larger MTUs might be different.
Yes; the good news is that without the fixed-size buffers,
memory use is only for the pending traffic, greatly improving scalability.
The bad news is that the allocs and frees will have a performance cost,
which I'm hoping will be balanced or bettered by removing the copy.
Anyway, I'll repost when I have all this ready.
+-DLS
next prev parent reply other threads:[~2014-09-23 16:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 0:11 [PATCHv6 net-next 1/3] sunvnet: upgrade to VIO protocol version 1.6 David L Stevens
2014-09-18 4:09 ` Raghuram Kothakota
2014-09-18 13:03 ` David L Stevens
2014-09-18 18:49 ` Raghuram Kothakota
2014-09-18 19:58 ` David L Stevens
2014-09-22 4:40 ` David L Stevens
2014-09-22 16:40 ` Raghuram Kothakota
2014-09-23 16:24 ` David Miller
2014-09-23 16:49 ` David L Stevens [this message]
2014-09-23 18:44 ` David Miller
2014-09-24 14:43 ` David L Stevens
2014-09-18 4:23 ` Raghuram Kothakota
2014-09-18 13:21 ` David L Stevens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5421A497.9060903@oracle.com \
--to=david.stevens@oracle$(echo .)com \
--cc=Raghuram.Kothakota@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox