Subject: Re: [PATCH][net-next] ipv4: unnecessary to set err on no_route path

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 29 Sep 2014 15:57:01 +0400

Hello.

On 9/29/2014 1:16 PM, [email-masked] wrote:

> From: Li RongQing <[email-masked]>

> When the code skips to no_route label, it will skip to local_input at last,
> then err will be reset on the local_input path before exit function.

> Signed-off-by: Li RongQing <[email-masked]>
> ---
>   net/ipv4/route.c |   11 ++++-------
>   1 file changed, 4 insertions(+), 7 deletions(-)

> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index d4bd68d..403914b 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1704,11 +1704,9 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
>   	fl4.daddr = daddr;
>   	fl4.saddr = saddr;
>   	err = fib_lookup(net, &fl4, &res);
> -	if (err != 0) {
> -		if (!IN_DEV_FORWARD(in_dev))
> -			err = -EHOSTUNREACH;
> +	if (err != 0)
>   		goto no_route;
> -	}
> +

    This extra empty line is not needed.

>
>   	if (res.type == RTN_BROADCAST)
>   		goto brd_input;

WBR, Sergei