Subject: Re: [PATCH 33/34] netfilter: nf_tables: store and dump set policy

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 29 Sep 2014 20:14:59 +0400

On 09/29/2014 04:39 PM, Pablo Neira Ayuso wrote:

> From: Arturo Borrero <[email-masked]>

> We want to know in which cases the user explicitly sets the policy
> options. In that case, we also want to dump back the info.

> Signed-off-by: Arturo Borrero Gonzalez <[email-masked]>
> Signed-off-by: Pablo Neira Ayuso <[email-masked]>
> ---
>   include/net/netfilter/nf_tables.h |    2 ++
>   net/netfilter/nf_tables_api.c     |    6 ++++++
>   2 files changed, 8 insertions(+)

> diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h
> index c4d8619..3d72923 100644
> --- a/include/net/netfilter/nf_tables.h
> +++ b/include/net/netfilter/nf_tables.h
[...]
> index a476b99..19e79f0 100644
> --- a/net/netfilter/nf_tables_api.c
> +++ b/net/netfilter/nf_tables_api.c
> @@ -2344,6 +2344,11 @@ static int nf_tables_fill_set(struct sk_buff *skb, const struct nft_ctx *ctx,
>   			goto nla_put_failure;
>   	}
>
> +	if (set->policy != NFT_SET_POL_PERFORMANCE) {
> +		if (nla_put_be32(skb, NFTA_SET_POLICY, htonl(set->policy)))
> +			goto nla_put_failure;

    Why not fold these two *if* stetement into a single one?

WBR, Sergei