From: David L Stevens <david.stevens@oracle•com>
To: Sowmini Varadhan <sowmini.varadhan@oracle•com>
Cc: davem@davemloft•net, raghuram.kothakota@oracle•com,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next 2/2] sunvnet: vnet_start_xmit() must hold a refcnt on port.
Date: Wed, 01 Oct 2014 15:31:49 -0400 [thread overview]
Message-ID: <542C56A5.4070805@oracle.com> (raw)
In-Reply-To: <20141001192325.GK17706@oracle.com>
On 10/01/2014 03:23 PM, Sowmini Varadhan wrote:
> On (10/01/14 15:06), David L Stevens wrote:
>>
>> This "vp->switch_port" addition doesn't appear to be related to the port refcnt
>> change, and doesn't allow for multiple switch ports.
>
> The switch_port is the connection to Dom0. Do you envision us having more than
> one switch_port? How?
While Dom0 might only create one port with the "switch" flag, the flag just means
"I can reach anybody" and is not inherently unique. I don't think an attached
VM should assume there is always only one; it prevents multipath load balancing
kinds of things in the future.
Also, there is the broader point that this sort of change should be a separate patch.
It isn't required for fixing the dangling reference -- it is an independent change.
+-DLS
next prev parent reply other threads:[~2014-10-01 19:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 18:56 [PATCH net-next 2/2] sunvnet: vnet_start_xmit() must hold a refcnt on port Sowmini Varadhan
2014-10-01 19:05 ` Eric Dumazet
2014-10-01 19:44 ` Sowmini Varadhan
2014-10-01 20:15 ` Eric Dumazet
2014-10-01 20:19 ` Sowmini Varadhan
2014-10-01 20:24 ` David Miller
2014-10-01 19:06 ` David L Stevens
2014-10-01 19:23 ` Sowmini Varadhan
2014-10-01 19:31 ` David L Stevens [this message]
2014-10-01 19:52 ` David Miller
2014-10-02 3:36 ` Raghuram Kothakota
2014-10-02 3:23 ` Raghuram Kothakota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542C56A5.4070805@oracle.com \
--to=david.stevens@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=raghuram.kothakota@oracle$(echo .)com \
--cc=sowmini.varadhan@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox