From: Ulf Samuelsson <ulf.samuelsson@ericsson•com>
To: Dan Williams <dcbw@redhat•com>, Ulf samuelsson <netdev@emagii•com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion•org>,
Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: netlink NETLINK_ROUTE failure & Can the kernel really handle IPv6 properly
Date: Fri, 3 Oct 2014 07:59:10 +0200 [thread overview]
Message-ID: <542E3B2E.2020909@ericsson.com> (raw)
In-Reply-To: <1412264648.7227.9.camel@dcbw.local>
On 10/02/2014 05:44 PM, Dan Williams wrote:
> On Thu, 2014-10-02 at 14:38 +0200, Ulf samuelsson wrote:
>> This is the significant code, and it is wrong.
>>
>> static struct notifier_block my_ipv6_address_notifier =
>> {
>> my_ipv6_address_notifier_cb,
>> NULL,
>> 0
>> };
>>
>> register_inet6addr_notifier (&my_ipv6_address_notifier );
>>
>> int
>> my_ipv6_address_notifier_cb (struct notifier_block *self,
>> unsigned long event, void *val)
>> {
>> struct inet6_ifaddr *ifaddr = (struct inet6_ifaddr *)val;
>>
>>
>> /* We are only interested in address add/delete events */
>> /* IPv6 address add comes as NETDEV_UP and delete comes as
>> * NETDEV_DOWN
>> */
>> if ((event != NETDEV_UP) && (event != NETDEV_DOWN))
>> return ret;
>>
>> if (ifaddr == NULL)
>> return ret;
>> /* Now that we are sure that it is a IPv6 address being added deleted,
>> * verify that it is a link local address.
>> */
>> if (!IPV6_IS_ADDR_LINKLOCAL (&ifaddr->addr))
>> {
>> return ret;
>> }
>> ...
>> send_message_to_app(LINK_LOCAL_UP, ip);
>> ...
>> return ret;
>> }
>>
>>
>> Application tries to send message to "ip" and fails, because the link-local adress is still
>> in "tentative state"
> It seems to me that a better architecture would be to have the app
> itself listen for RTM_NEWADDR netlink event and look for lack of
> IFA_F_TENTATIVE in the IFA_FLAGS attribute. Using a kernel module to do
> the same thing seems pretty wrong.
>
> Dan
Thanks, Maybe you are right but I do not have all the details.
The kernel module is part of a driver for a Broadcom router chip.
The guys writing the driver might want to know as well.
I will see what they say.
Best Regards,
Ulf Samuelsson
>> Best Regards
>> Ulf Samuelsson
>> ulf@emagii•com
>> +46 (722) 427 437
>>
>>
>>> 1 okt 2014 kl. 23:30 skrev Hannes Frederic Sowa <hannes@stressinduktion•org>:
>>>
>>> Hello,
>>>
>>>> On Wed, Oct 1, 2014, at 22:28, Ulf Samuelsson wrote:
>>>> BTW, the problem I am trying to solve is how to connect to an I/F with
>>>> an IPv6 link-local address.
>>>>
>>>> An existing kernel module waits for a NETDEV_UP event, and then tries to
>>>> communicate
>>>> with the link-local address.
>>>>
>>>> This will fail, because (according to a colleague) the I/F enters a
>>>> "tentative" state,
>>>> where it is trying to decide if it is unique or not.
>>>> It will remain in that state for 1-2 seconds, and only afterwards is the
>>>> link-local address
>>>> available for normal use.
>>>>
>>>> The guys writing the module, claim that the kernel is using NETDEV_UP.
>>>> There is very little code in the kernel using NETLINK_ROUTE, even in
>>>> latest stable.
>>>> It is using NETDEV_UP.
>>>>
>>>> If my colleague is right, the kernel really cannot handle IPv6
>>>> link-local addresses properly.
>>> Sorry, I cannot really follow you, can you send example code or be a bit
>>> more precise?
>>>
>>> Thanks,
>>> Hannes
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>>> the body of a message to majordomo@vger•kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger•kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-03 5:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 20:28 netlink NETLINK_ROUTE failure & Can the kernel really handle IPv6 properly Ulf Samuelsson
2014-10-01 21:30 ` Hannes Frederic Sowa
2014-10-02 12:38 ` Ulf samuelsson
2014-10-02 15:44 ` Dan Williams
2014-10-03 5:59 ` Ulf Samuelsson [this message]
2014-10-03 7:59 ` Ulf Samuelsson
2014-10-03 18:49 ` David Miller
2014-10-06 11:25 ` Ulf Samuelsson
2014-10-06 3:35 ` Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542E3B2E.2020909@ericsson.com \
--to=ulf.samuelsson@ericsson$(echo .)com \
--cc=dcbw@redhat$(echo .)com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=netdev@emagii$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox