Subject: Re: macvlan: optimizing the receive path?

From: Jason Baron <[email-masked]>
Date: Fri, 03 Oct 2014 11:08:10 -0400

On 10/02/2014 05:31 PM, Stephen Hemminger wrote:
> On Thu, 02 Oct 2014 16:28:13 -0400
> Jason Baron <[email-masked]> wrote:
> 
>> Hi,
>>
>> I was just wondering why the netif_rx(skb) call in macvlan_handle_frame()
>> was necessary? IE:
> 
> 
> It is to prevent too deep a call stack of
>   netif_receive_skb
>      macvlan_receive
>         netif_receive_skb ...
> 

So the concern is a stack overflow? The above nesting would really look like:

netif_receive_skb
        macvlan_receive
netif_receive_skb

b/c the macvlan_receive call would return. So its not clear to me that the
macvlan code would be adding to the stack depth here.

Thanks,

-Jason