Subject: Re: [Patch net-next] net_sched: refactor out tcf_exts

From: Jamal Hadi Salim <[email-masked]>
Date: Mon, 06 Oct 2014 07:09:49 -0400

On 10/03/14 18:51, Cong Wang wrote:
> As Jamal pointed it out, tcf_exts is really unnecessary,
> we can definitely refactor it out without losing any functionality.
> This could also remove an indirect layer which makes the code
> much easier to read.
>
> This patch:
>
> 1) moves exts->action and exts->police into tp->ops, since they
> are statically assigned
>
> 2) moves exts->actions list head out
>
> 3) removes exts->type, act->type does the same thing
>
> 4) renames tcf_exts_*() functions to tcf_act_*()
>
> Cc: Jamal Hadi Salim <[email-masked]>
> Cc: John Fastabend <[email-masked]>
> Cc: "David S. Miller" <[email-masked]>
> Signed-off-by: Cong Wang <[email-masked]>

Thanks for doing the work Cong.
I noticed John points to an issue in his testing; but
please add my:
Acked-by: Jamal Hadi Salim <[email-masked]>

I will start sending incremental patches to iproute2 to slowly get
rid of direct police interfacing which will allow us to get rid of
.police dereference altogether.
It was a mistake not to do it years ago.
One way to accelerate it right now is to log a "deprecated"
message everytime someone uses TCA_XXX_POLICE attributes.

cheers,
jamal