From: Amir Vadai <amirv@mellanox•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>, <netdev@vger•kernel.org>,
Yevgeny Petrilin <yevgenyp@mellanox•com>,
Or Gerlitz <ogerlitz@mellanox•com>,
Ido Shamay <idos@mellanox•com>
Subject: Re: [PATCH net-next V1 00/14] net/mlx4_en: Optimizations to TX flow
Date: Mon, 6 Oct 2014 15:54:00 +0300 [thread overview]
Message-ID: <543290E8.3070609@mellanox.com> (raw)
In-Reply-To: <1412599904.11091.66.camel@edumazet-glaptop2.roam.corp.google.com>
On 10/6/2014 3:51 PM, Eric Dumazet wrote:
> On Mon, 2014-10-06 at 09:15 +0300, Amir Vadai wrote:
>
>> Changes from V0:
>> - Patch 14/14 ("Use the new tx_copybreak to set inline threshold"):
>> - Use same coding convention as currently is in en_ethtool.c
>> - Patch 1/14 ("Code cleanups in tx path") and Patch 9/14 ("Use local var in
>> tx flow for skb_shinfo(skb)"):
>> - local var shinfo was used by mistake in Patch 1/14 while declared at 9/14.
>> Fixed it for the sake of future bisections
>
> Hmm... patches were already merged. I am afraid you need to provide one
> patch on top of current net-next, if still needed. Too bad for the
> bisection.
>
> Thanks !
>
>
Yeh, I missed it somehow. Sorry for the spam.
Amir
next prev parent reply other threads:[~2014-10-06 12:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 6:15 [PATCH net-next V1 00/14] net/mlx4_en: Optimizations to TX flow Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 01/14] net/mlx4_en: Code cleanups in tx path Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 02/14] net/mlx4_en: Align tx path structures to cache lines Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 03/14] net/mlx4_en: Avoid calling bswap in tx fast path Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 04/14] net/mlx4_en: tx_info allocated with kmalloc() instead of vmalloc() Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 05/14] net/mlx4_en: Avoid a cache line miss in TX completion for single frag skb's Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 06/14] net/mlx4_en: Use prefetch in tx path Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 07/14] net/mlx4_en: Avoid false sharing in mlx4_en_en_process_tx_cq() Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 08/14] net/mlx4_en: mlx4_en_xmit() reads ring->cons once, and ahead of time to avoid stalls Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 09/14] net/mlx4_en: Use local var in tx flow for skb_shinfo(skb) Amir Vadai
2014-10-06 6:15 ` [PATCH net-next V1 10/14] net/mlx4_en: Use local var for skb_headlen(skb) Amir Vadai
2014-10-06 6:16 ` [PATCH net-next V1 11/14] net/mlx4_en: tx_info->ts_requested was not cleared Amir Vadai
2014-10-06 6:16 ` [PATCH net-next V1 12/14] net/mlx4_en: Enable the compiler to make is_inline() inlined Amir Vadai
2014-10-06 6:16 ` [PATCH net-next V1 13/14] ethtool: Ethtool parameter to dynamically change tx_copybreak Amir Vadai
2014-10-06 6:16 ` [PATCH net-next V1 14/14] net/mlx4_en: Use the new tx_copybreak to set inline threshold Amir Vadai
2014-10-06 12:51 ` [PATCH net-next V1 00/14] net/mlx4_en: Optimizations to TX flow Eric Dumazet
2014-10-06 12:54 ` Amir Vadai [this message]
2014-10-06 16:30 ` [PATCH net-next] net/mlx4_en: remove NETDEV_TX_BUSY Eric Dumazet
2014-10-07 8:30 ` Amir Vadai
2014-10-07 12:38 ` Eric Dumazet
2014-10-07 17:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543290E8.3070609@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=idos@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox