From: Krzysztof Kolasa <kkolasa@winsoft•pl>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Cong Wang <cwang@twopensource•com>,
David Miller <davem@davemloft•net>,
Eric Dumazet <edumazet@gmail•com>,
netdev <netdev@vger•kernel.org>
Subject: Re: something is wrong in commit 971f10eca1 - tcp: better TCP_SKB_CB layout to reduce cache line misses
Date: Wed, 15 Oct 2014 13:40:15 +0200 [thread overview]
Message-ID: <543E5D1F.2020207@winsoft.pl> (raw)
In-Reply-To: <1413372422.17365.10.camel@edumazet-glaptop2.roam.corp.google.com>
W dniu 15.10.2014 o 13:27, Eric Dumazet pisze:
> On Wed, 2014-10-15 at 12:35 +0200, Krzysztof Kolasa wrote:
>> W dniu 14.10.2014 o 23:43, Eric Dumazet pisze:
>>> On Tue, 2014-10-14 at 14:24 -0700, Cong Wang wrote:
>>>
>>>> Since we are still in merge window, I don't think we have to use
>>>> a one-line fix for a bug introduced in this merge window.
>>> You are clearly refactoring here. Its a nice cleanup.
>>>
>>> If I was the maintainer, I would prefer the one line fix.
>>>
>>> Then when net-next is open, you refactor.
>>>
>>> As I said, I wont argue, do whatever you want.
>>>
>>> Thanks
>>>
>>>
>>>
>> one-line patch not resolve problem, fix created by Cong Wang resolves
>> problem !!!
> Hmm, there should be no difference with either patch.
>
> tcp_v4_rcv()
> ...
> memmove(&TCP_SKB_CB(skb)->header.h4, IPCB(skb),
> sizeof(struct inet_skb_parm));
> ...
> -> tcp_v4_do_rcv()
> -> tcp_v4_hnd_req()
> -> cookie_v4_check(... , &TCP_SKB_CB(skb)->header.h4.opt)
>
> Hmm...
>
>
on a 32bit system, the patch did not solve the problem :(
I have exactly the same problem as before the patch
I do not understand this, perhaps the problem is hidden somewhere else,
one thing is certain after revert commit 971f10eca1 everything works
correctly
next prev parent reply other threads:[~2014-10-15 11:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 17:11 something is wrong in commit 971f10eca1 - tcp: better TCP_SKB_CB layout to reduce cache line misses Krzysztof Kolasa
2014-10-12 18:46 ` Eric Dumazet
2014-10-13 23:59 ` Cong Wang
2014-10-14 0:09 ` Cong Wang
2014-10-14 13:25 ` Krzysztof Kolasa
2014-10-14 18:59 ` Cong Wang
2014-10-14 19:03 ` David Miller
[not found] ` <CAFrEnehWNzmzZGV-ZGbZF=wJ1q0TjFtB1yG6Dp1yVrJmBj9B7Q@mail.gmail.com>
2014-10-14 20:47 ` David Miller
2014-10-14 21:03 ` Eric Dumazet
2014-10-14 21:15 ` David Miller
2014-10-14 21:24 ` Cong Wang
2014-10-14 21:43 ` Eric Dumazet
2014-10-15 10:35 ` Krzysztof Kolasa
2014-10-15 11:27 ` Eric Dumazet
2014-10-15 11:40 ` Krzysztof Kolasa [this message]
2014-10-15 15:32 ` Eric Dumazet
2014-10-15 20:20 ` Krzysztof Kolasa
2014-10-15 20:36 ` Cong Wang
2014-10-15 20:42 ` Krzysztof Kolasa
2014-10-15 21:22 ` Cong Wang
2014-10-15 21:25 ` Cong Wang
2014-10-15 21:39 ` Eric Dumazet
2014-10-15 21:42 ` Eric Dumazet
2014-10-17 19:29 ` David Miller
2014-10-17 19:48 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543E5D1F.2020207@winsoft.pl \
--to=kkolasa@winsoft$(echo .)pl \
--cc=cwang@twopensource$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@gmail$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox