Subject: Re: [PATCH 8/9] ARM: berlin: Add phy-connection-type to BG2Q PHY

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 21 Oct 2014 15:31:13 +0400

Hello.

On 10/21/2014 12:53 PM, Sebastian Hesselbarth wrote:

> From: Antoine Ténart <[email-masked]>

> Internal FastEthernet PHY on BG2Q is connected via MII, add a
> corresponding phy-connection-type property.

> Tested-by: Antoine Ténart <[email-masked]>
> Signed-off-by: Sebastian Hesselbarth <[email-masked]>
> ---
> Cc: "David S. Miller" <[email-masked]>
> Cc: "Antoine Ténart" <[email-masked]>
> Cc: Florian Fainelli <[email-masked]>
> Cc: Eric Miao <[email-masked]>
> Cc: Haojian Zhuang <[email-masked]>
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> ---
>   arch/arm/boot/dts/berlin2q.dtsi | 1 +
>   1 file changed, 1 insertion(+)

> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> index 891d56b03922..6dbc520bddc1 100644
> --- a/arch/arm/boot/dts/berlin2q.dtsi
> +++ b/arch/arm/boot/dts/berlin2q.dtsi
> @@ -127,6 +127,7 @@
>   			status = "disabled";
>
>   			ethphy0: ethernet-phy@0 {
> +				phy-connection-type = "mii";

    You're adding this prop to the PHY node? That's very weird... normally, 
it's a property of a MDIO bus node.

[...]

WBR, Sergei