From: Varka Bhadram <varkabhadram@gmail•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
netdev@vger•kernel.org
Cc: Varka Bhadram <varkab@cdac•in>
Subject: Re: [PATCH net-next 1/6] ethernet: wiznet: remove unnecessary check
Date: Wed, 22 Oct 2014 17:53:46 +0530 [thread overview]
Message-ID: <5447A1D2.8050107@gmail.com> (raw)
In-Reply-To: <54479876.5050202@cogentembedded.com>
On 10/22/2014 05:13 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 10/22/2014 8:16 AM, Varka Bhadram wrote:
>
>> devm_ioremap_resource checks platform_get_resource() return value.
>> We can remove the duplicate check here.
>
>> Signed-off-by: Varka Bhadram <varkab@cdac•in>
>> ---
>> drivers/net/ethernet/wiznet/w5100.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>> diff --git a/drivers/net/ethernet/wiznet/w5100.c
>> b/drivers/net/ethernet/wiznet/w5100.c
>> index 0f56b1c..bf195e3 100644
>> --- a/drivers/net/ethernet/wiznet/w5100.c
>> +++ b/drivers/net/ethernet/wiznet/w5100.c
>> @@ -638,8 +638,7 @@ static int w5100_hw_probe(struct platform_device
>> *pdev)
>> }
>>
>> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!mem)
>> - return -ENXIO;
>> +
>> mem_size = resource_size(mem);
>
> This would cause a NULL dereference on resource_size() call if
> 'mem' is NULL. You can't remove the NULL check because of that.
>
Ok i will fix it . Thankx for the review.
>>
>> priv->base = devm_ioremap_resource(&pdev->dev, mem);
>>
>
> WBR, Sergei
>
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-10-22 12:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <N>
2014-10-22 4:16 ` [PATCH net-next 0/6] cleanup on resource check Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 1/6] ethernet: wiznet: remove unnecessary check Varka Bhadram
2014-10-22 11:43 ` Sergei Shtylyov
2014-10-22 12:23 ` Varka Bhadram [this message]
2014-10-22 4:16 ` [PATCH net-next 2/6] " Varka Bhadram
2014-10-22 11:44 ` Sergei Shtylyov
2014-10-22 12:24 ` Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 3/6] ethernet: apm: xgene: " Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 4/6] ethernet: marvell: " Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 5/6] ethernet: renesas: " Varka Bhadram
2014-10-22 11:47 ` Sergei Shtylyov
2014-10-22 12:22 ` Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 6/6] ethernet: samsung: sxgbe: " Varka Bhadram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447A1D2.8050107@gmail.com \
--to=varkabhadram@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=varkab@cdac$(echo .)in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox