From: Edward Cree <ecree@solarflare•com>
To: Ben Hutchings <ben@decadent•org.uk>
Cc: Robert Stonehouse <rstonehouse@solarflare•com>,
Daniel Borkmann <dborkman@redhat•com>, <davem@davemloft•net>,
<nikolay@redhat•com>, <netdev@vger•kernel.org>,
Shradha Shah <sshah@solarflare•com>,
Jon Cooper <jcooper@solarflare•com>,
linux-net-drivers <linux-net-drivers@solarflare•com>
Subject: Re: [PATCH net-next] sfc: add support for skb->xmit_more
Date: Wed, 22 Oct 2014 13:36:21 +0100 [thread overview]
Message-ID: <5447A4C5.90802@solarflare.com> (raw)
In-Reply-To: <1413968323.5994.6.camel@decadent.org.uk>
On 22/10/14 09:58, Ben Hutchings wrote:
> On Fri, 2014-10-17 at 15:32 +0100, Edward Cree wrote:
> [...]
>> @@ -351,7 +343,7 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb)
>> unsigned short dma_flags;
>> int i = 0;
>>
>> - EFX_BUG_ON_PARANOID(tx_queue->write_count != tx_queue->insert_count);
>> + EFX_BUG_ON_PARANOID(tx_queue->write_count > tx_queue->insert_count);
> [...]
>
> Doesn't this break after 2^32 descriptors? It seems like you would need
> a similar comparison to time_after(); possibly:
>
> EFX_BUG_ON_PARANOID((int)(tx_queue->write_count - tx_queue->insert_count) > 0);
>
> Ben.
>
Yes, Jon already spotted that. We just diked it out - see "[PATCH net]
sfc: remove incorrect EFX_BUG_ON_PARANOID check"
http://patchwork.ozlabs.org/patch/401503/
But your suggestion is a good one; feel free to post as a new patch on
that thread.
-Edward
prev parent reply other threads:[~2014-10-22 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 16:59 [PATCH] sfc: efx: add support for skb->xmit_more Daniel Borkmann
2014-10-13 18:02 ` Edward Cree
2014-10-13 19:18 ` Daniel Borkmann
2014-10-14 18:41 ` [PATCH RFC net-next] sfc: " Edward Cree
2014-10-14 21:15 ` David Miller
2014-10-15 11:05 ` Edward Cree
2014-10-15 16:20 ` David Miller
2014-10-16 15:42 ` Jonathan Cooper
2014-10-16 16:36 ` Robert Stonehouse
2014-10-17 14:32 ` [PATCH " Edward Cree
2014-10-18 3:47 ` David Miller
2014-10-22 8:58 ` Ben Hutchings
2014-10-22 12:36 ` Edward Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447A4C5.90802@solarflare.com \
--to=ecree@solarflare$(echo .)com \
--cc=ben@decadent$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=jcooper@solarflare$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@redhat$(echo .)com \
--cc=rstonehouse@solarflare$(echo .)com \
--cc=sshah@solarflare$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox