Subject: Re: [PATCH v2 net] tcp: zero retrans_stamp if all retrans were acked

From: Marcelo Ricardo Leitner <[email-masked]>
Date: Tue, 04 Nov 2014 18:51:37 -0200

On 04-11-2014 18:10, Neal Cardwell wrote:
> On Tue, Nov 4, 2014 at 2:15 PM, Marcelo Ricardo Leitner
> <[email-masked]> wrote:
> ...
>> Therefore, now we clear retrans_stamp as soon as all data during the
>> loss window is fully acked.
>>
>> Reported-by: Ueki Kohei
>> Cc: Neal Cardwell <[email-masked]>
>> Cc: Yuchung Cheng <[email-masked]>
>> Signed-off-by: Marcelo Ricardo Leitner <[email-masked]>
>> ---
>>
>> Notes:
>>      v1->v2: fixed compilation issue noticed by Neal
>>
>>   net/ipv4/tcp_input.c | 60 +++++++++++++++++++++++++++-------------------------
>>   1 file changed, 31 insertions(+), 29 deletions(-)
>
> Acked-by: Neal Cardwell <[email-masked]>
> Tested-by: Neal Cardwell <[email-masked]>
>
> Code looks fine, and it passes Yuchung's packetdrill test case for this.
>
> Thanks for finding and fixing this, Marcelo.

And thank you guys for all the assistance on it. Btw, would you send me that 
packetdrill script? I'm curious to see how such corner case could be written 
on it.

Regards,
Marcelo