public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Daniel Borkmann <dborkman@redhat•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: davem@davemloft•net, lw1a2.jing@gmail•com, fw@strlen•de,
	hannes@stressinduktion•org, netdev@vger•kernel.org,
	Eric Dumazet <edumazet@google•com>,
	David L Stevens <david.stevens@oracle•com>
Subject: Re: [PATCH net] ipv6: mld: fix add_grhead skb_over_panic for devs with large MTUs
Date: Wed, 05 Nov 2014 13:09:13 +0100	[thread overview]
Message-ID: <545A1369.2040309@redhat.com> (raw)
In-Reply-To: <1415149616.30247.1.camel@edumazet-glaptop2.roam.corp.google.com>

On 11/05/2014 02:06 AM, Eric Dumazet wrote:
> On Wed, 2014-11-05 at 01:58 +0100, Daniel Borkmann wrote:
>> It has been reported that generating an MLD listener report on
>> devices with large MTUs (e.g. 9000) and a high number of IPv6
>> addresses can trigger a skb_over_panic():
>>
[...]
>>
>> Reported-by: lw1a2.jing@gmail•com
>> Fixes: 72e09ad107e7 ("ipv6: avoid high order allocations")
>> Signed-off-by: Daniel Borkmann <dborkman@redhat•com>
>> Cc: Eric Dumazet <edumazet@google•com>
>> Cc: David L Stevens <david.stevens@oracle•com>
>> ---
>>   In skb_nofrag_tailroom(), we could actually omit the !skb->dev check,
>>   but I leave that rather as a possible cleanup item for net-next.

Thanks for your feedback!

> Hmm... we have a proliferation of such things.
>
> Could you take a look at sk_stream_alloc_skb(), skb->reserved_tailroom,
> and skb_availroom() ?

Ok, here would be a proposal based on skb_availroom():

   http://patchwork.ozlabs.org/patch/406959/

Thanks,
Daniel

     prev parent reply	other threads:[~2014-11-05 12:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05  0:58 [PATCH net] ipv6: mld: fix add_grhead skb_over_panic for devs with large MTUs Daniel Borkmann
2014-11-05  1:06 ` Eric Dumazet
2014-11-05 12:09   ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545A1369.2040309@redhat.com \
    --to=dborkman@redhat$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=david.stevens@oracle$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=fw@strlen$(echo .)de \
    --cc=hannes@stressinduktion$(echo .)org \
    --cc=lw1a2.jing@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox