From: Daniel Borkmann <dborkman@redhat•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: davem@davemloft•net, lw1a2.jing@gmail•com, fw@strlen•de,
hannes@stressinduktion•org, netdev@vger•kernel.org,
Eric Dumazet <edumazet@google•com>,
David L Stevens <david.stevens@oracle•com>
Subject: Re: [PATCH net v3] ipv6: mld: fix add_grhead skb_over_panic for devs with large MTUs
Date: Wed, 05 Nov 2014 17:26:42 +0100 [thread overview]
Message-ID: <545A4FC2.4010109@redhat.com> (raw)
In-Reply-To: <1415204413.13896.5.camel@edumazet-glaptop2.roam.corp.google.com>
On 11/05/2014 05:20 PM, Eric Dumazet wrote:
> On Wed, 2014-11-05 at 15:42 +0100, Daniel Borkmann wrote:
>> It has been reported that generating an MLD listener report on
>> devices with large MTUs (e.g. 9000) and a high number of IPv6
>> addresses can trigger a skb_over_panic():
> ...
>> v2->v3:
>> - Still had a discussion w/ Hannes and improved the code a bit to
>> make it more clear to read
>
> I am very sorry Daniel, but I found v2 much easier to understand :(
>
> Could you refrain from doing cleanups in this patch,
> only provide the very minimal fix ?
>
> No empty lines additions or deletions and stuff like that...
>
> Then, we can cleanup for net-next later if you really want ;)
>
> I know its _very_ tempting to do cleanups, but its very time consuming
> to review patches having real stuff done (like bug fixes) and cleanups.
I can understand, sorry, I'm fine with either version actually.
Thanks,
Daniel
next prev parent reply other threads:[~2014-11-05 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 14:42 [PATCH net v3] ipv6: mld: fix add_grhead skb_over_panic for devs with large MTUs Daniel Borkmann
2014-11-05 16:20 ` Eric Dumazet
2014-11-05 16:26 ` Daniel Borkmann [this message]
2014-11-05 16:38 ` Hannes Frederic Sowa
2014-11-05 16:48 ` Eric Dumazet
2014-11-05 17:59 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A4FC2.4010109@redhat.com \
--to=dborkman@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david.stevens@oracle$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=hannes@stressinduktion$(echo .)org \
--cc=lw1a2.jing@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox