From: Florian Fainelli <f.fainelli@gmail•com>
To: Jiri Pirko <jiri@resnulli•us>, netdev@vger•kernel.org
Cc: davem@davemloft•net, nhorman@tuxdriver•com, andy@greyhouse•net,
tgraf@suug•ch, dborkman@redhat•com, ogerlitz@mellanox•com,
jesse@nicira•com, pshelar@nicira•com, azhou@nicira•com,
ben@decadent•org.uk, stephen@networkplumber•org,
jeffrey.t.kirsher@intel•com, vyasevic@redhat•com,
xiyou.wangcong@gmail•com, john.r.fastabend@intel•com,
edumazet@google•com, jhs@mojatatu•com, sfeldma@gmail•com,
roopa@cumulusnetworks•com, linville@tuxdriver•com,
jasowang@redhat•com, ebiederm@xmission•com,
nicolas.dichtel@6wind•com, ryazanov.s.a@gmail•com,
buytenh@wantstofly•org, aviadr@mellanox•com, nbd@openwrt•org,
alexei.starovoitov@gmail•com, Neil.Jerram@metaswitch•com,
ronye@mellanox•com, simon.horman@netronome•com,
alexander.h.duyck@redhat•com, john.ronciak@intel•com,
mleitner@redhat•com, shrijeet@gmail•com,
gospo@cumulusnetworks•com, bcrl@kvack•org
Subject: Re: [patch net-next 07/10] bridge: call netdev_sw_port_stp_update when bridge port STP status changes
Date: Thu, 06 Nov 2014 08:59:27 -0800 [thread overview]
Message-ID: <545BA8EF.4060601@gmail.com> (raw)
In-Reply-To: <1415265610-9338-8-git-send-email-jiri@resnulli.us>
On 11/06/2014 01:20 AM, Jiri Pirko wrote:
> From: Scott Feldman <sfeldma@gmail•com>
>
> To notify switch driver of change in STP state of bridge port, add new
> .ndo op and provide swdev wrapper func to call ndo op. Use it in bridge
> code then.
>
> Signed-off-by: Scott Feldman <sfeldma@gmail•com>
> Signed-off-by: Jiri Pirko <jiri@resnulli•us>
> ---
[snip]
> #endif /* _LINUX_SWITCHDEV_H_ */
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index 86c239b..13fecf1 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -17,6 +17,7 @@
> #include <net/net_namespace.h>
> #include <net/sock.h>
> #include <uapi/linux/if_bridge.h>
> +#include <net/switchdev.h>
>
> #include "br_private.h"
> #include "br_private_stp.h"
> @@ -304,6 +305,7 @@ static int br_set_port_state(struct net_bridge_port *p, u8 state)
>
> br_set_state(p, state);
> br_log_state(p);
> + netdev_sw_port_stp_update(p->dev, p->state);
Is there a reason netdev_sw_port_stp_update() is not folded in
br_set_state()? Are we missing calls to br_set_state() in some locations?
--
Florian
next prev parent reply other threads:[~2014-11-06 17:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 9:20 [patch net-next 00/10] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload Jiri Pirko
2014-11-06 9:20 ` [patch net-next 01/10] net: rename netdev_phys_port_id to more generic name Jiri Pirko
2014-11-06 9:20 ` [patch net-next 02/10] net: introduce generic switch devices support Jiri Pirko
2014-11-06 9:20 ` [patch net-next 03/10] rtnl: expose physical switch id for particular device Jiri Pirko
2014-11-06 9:20 ` [patch net-next 04/10] net-sysfs: " Jiri Pirko
2014-11-06 9:20 ` [patch net-next 05/10] rocker: introduce rocker switch driver Jiri Pirko
2014-11-07 20:08 ` David Miller
2014-11-06 9:20 ` [patch net-next 06/10] bridge: introduce fdb offloading via switchdev Jiri Pirko
2014-11-07 20:12 ` David Miller
2014-11-06 9:20 ` [patch net-next 07/10] bridge: call netdev_sw_port_stp_update when bridge port STP status changes Jiri Pirko
2014-11-06 16:59 ` Florian Fainelli [this message]
2014-11-06 18:57 ` Scott Feldman
[not found] ` <CAE4R7bBarGQPsuM5js20RwPLOBF24AtiiHM-f2EvkHNObp7NDQ@mail.gmail.com>
2014-11-07 8:32 ` Jiri Pirko
2014-11-06 9:20 ` [patch net-next 08/10] bridge: add API to notify bridge driver of learned FBD on offloaded device Jiri Pirko
2014-11-06 9:20 ` [patch net-next 09/10] rocker: implement rocker ofdpa flow table manipulation Jiri Pirko
2014-11-07 20:16 ` David Miller
2014-11-07 21:15 ` [PATCH] checkpatch: Add --strict preference for #defines using BIT(foo) Joe Perches
2014-11-09 9:50 ` Jiri Pirko
2014-11-09 14:22 ` Joe Perches
2014-11-10 23:36 ` Andrew Morton
2014-11-10 23:53 ` Joe Perches
2014-11-06 9:20 ` [patch net-next 10/10] rocker: implement L2 bridge offloading Jiri Pirko
2014-11-07 20:16 ` David Miller
2014-11-06 14:11 ` [patch net-next 00/10] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload Thomas Graf
2014-11-06 14:32 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545BA8EF.4060601@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=Neil.Jerram@metaswitch$(echo .)com \
--cc=alexander.h.duyck@redhat$(echo .)com \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=aviadr@mellanox$(echo .)com \
--cc=azhou@nicira$(echo .)com \
--cc=bcrl@kvack$(echo .)org \
--cc=ben@decadent$(echo .)org.uk \
--cc=buytenh@wantstofly$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse@nicira$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=mleitner@redhat$(echo .)com \
--cc=nbd@openwrt$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=pshelar@nicira$(echo .)com \
--cc=ronye@mellanox$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=ryazanov.s.a@gmail$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=shrijeet@gmail$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox