From: David Ahern <dsahern@gmail•com>
To: Phil Sutter <phil@nwl•cc>, Andrea Claudi <aclaudi@redhat•com>,
netdev@vger•kernel.org, stephen@networkplumber•org,
bluca@debian•org
Subject: Re: [PATCH iproute2 v3 1/3] configure: support --param=value style
Date: Wed, 6 Oct 2021 08:27:51 -0600 [thread overview]
Message-ID: <54638ccd-deb5-1212-b2fc-876ceaee67da@gmail.com> (raw)
In-Reply-To: <20211006101857.GB29206@orbyte.nwl.cc>
On 10/6/21 4:18 AM, Phil Sutter wrote:
> Hi Andrea,
>
> On Wed, Oct 06, 2021 at 11:49:34AM +0200, Andrea Claudi wrote:
> [...]
>> That was my first proposal in v1 [1]. I changed it on David's suggestion
>> to consolidate the two cases into a single one.
>
> Oh, sorry. I missed the 'v3' tag and hence didn't check any earlier
> version.
>
>> Looking at the resulting code, v3 code results in an extra check to
>> discriminate between the two use cases, while v0 uses the "case"
>> structure to the same end.
>
> Given that David explicitly requested the change I'm complaining about
> in his reply to your initial version, I guess any further debate about
> it is irrelevant.
>
I did not like the exploding duplication of checks on the value just to
support '=' in the command line.
Phil's suggestion seems reasonable.
next prev parent reply other threads:[~2021-10-06 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 22:08 [PATCH iproute2 v3 0/3] configure: add support for libdir and prefix option Andrea Claudi
2021-10-05 22:08 ` [PATCH iproute2 v3 1/3] configure: support --param=value style Andrea Claudi
2021-10-06 8:09 ` Phil Sutter
2021-10-06 9:49 ` Andrea Claudi
2021-10-06 10:18 ` Phil Sutter
2021-10-06 14:27 ` David Ahern [this message]
2021-10-05 22:08 ` [PATCH iproute2 v3 2/3] configure: add the --prefix option Andrea Claudi
2021-10-05 22:08 ` [PATCH iproute2 v3 3/3] configure: add the --libdir option Andrea Claudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54638ccd-deb5-1212-b2fc-876ceaee67da@gmail.com \
--to=dsahern@gmail$(echo .)com \
--cc=aclaudi@redhat$(echo .)com \
--cc=bluca@debian$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=phil@nwl$(echo .)cc \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox