Subject: Re: [PATCH] net: sh_eth: Add RMII mode setting in probe

From: Sergei Shtylyov <[email-masked]>
Date: Fri, 14 Nov 2014 01:20:06 +0300

Hello.

On 11/13/2014 09:54 AM, Yoshihiro Kaneko wrote:

> From: Hisashi Nakamura <[email-masked]>

> When using RMMI mode, it is necessary to change in probe.

    I'd like this need to be explained in more detail.

> Signed-off-by: Hisashi Nakamura <[email-masked]>
> Signed-off-by: Yoshihiro Kaneko <[email-masked]>
> ---

> This patch is based on net-next tree.

>   drivers/net/ethernet/renesas/sh_eth.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index dbe8606..1f79ed6 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1,5 +1,6 @@
>   /*  SuperH Ethernet device driver
>    *
> + *  Copyright (C) 2014  Renesas Electronics Corporation
>    *  Copyright (C) 2006-2012 Nobuhiro Iwamatsu
>    *  Copyright (C) 2008-2014 Renesas Solutions Corp.
>    *  Copyright (C) 2013-2014 Cogent Embedded, Inc.
> @@ -2883,6 +2884,9 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
>   		}
>   	}
>
> +	if (mdp->cd->rmiimode)
> +		sh_eth_write(ndev, 0x1, RMIIMODE);
> +

    Does not such code need to be removed from sh_eth_dev_init() then?

WBR, Sergei