Subject: Re: [net-next 01/12] i40e: only warn once of PTP nonsupport in 100Mbit speed

From: Florian Fainelli <[email-masked]>
Date: Sat, 15 Nov 2014 13:20:58 -0800

Le 14/11/2014 22:08, Jeff Kirsher a écrit :
> From: Shannon Nelson <[email-masked]>
>
> Only warn once that PTP is not supported when linked at 100Mbit.
>
> Yes, using a static this way means that this once-only message is not
> port specific, but once only for the life of the driver, regardless of
> the number of ports.  That should be plenty.
>
> Change-ID: Ie6476530056df408452e195ef06afd4f57caa4b2
> Signed-off-by: Shannon Nelson <[email-masked]>
> Signed-off-by: Jeff Kirsher <[email-masked]>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_ptp.c | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40e/i40e_ptp.c
> index 537b621..f9151037 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c
> @@ -382,11 +382,17 @@ void i40e_ptp_set_increment(struct i40e_pf *pf)
>   		incval = I40E_PTP_1GB_INCVAL;
>   		break;
>   	case I40E_LINK_SPEED_100MB:
> -		dev_warn(&pf->pdev->dev,
> -			 "%s: 1588 functionality is not supported at 100 Mbps. Stopping the PHC.\n",
> -			 __func__);
> +	{
> +		static int warn_once;
> +
> +		if (!warn_once) {
> +			dev_warn(&pf->pdev->dev,
> +				 "1588 functionality is not supported at 100 Mbps. Stopping the PHC.\n");
> +			warn_once++;
> +		}

I am sure Joe could come up with dev_warn_once() and others pretty 
easily. As a temporary change you could use pr_warn_once("%s: ...\n", 
dev_name(&pf->pdev->dev) which is almost identical?

>   		incval = 0;
>   		break;
> +	}
>   	case I40E_LINK_SPEED_40GB:
>   	default:
>   		incval = I40E_PTP_40GB_INCVAL;
>