Subject: Re: [PATCH] bonding: clear header_ops when last slave detached (v2)

From: Wengang <[email-masked]>
Date: Wed, 19 Nov 2014 13:22:07 +0800

Hi Jay and Eric,

Could you please review the 2nd prompt?

thanks,
wengang

于 2014年11月19日 13:18, Wengang Wang 写道:
> When last slave of a bonding master is removed, the bonding then does not work.
> When packet_snd is called against with a master net_device, it accesses
> header_ops. In case the header_ops is not valid any longer(say ipoib module
> unloaded), it will then access an invalid memory address.
> This patch try to fix this issue by clearing header_ops when last slave
> detached.
>
> Signed-off-by: Wengang Wang <[email-masked]>
> ---
>   drivers/net/bonding/bond_main.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index c9ac06c..52a7e4b 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1730,6 +1730,7 @@ static int __bond_release_one(struct net_device *bond_dev,
>   	bond->slave_cnt--;
>   
>   	if (!bond_has_slaves(bond)) {
> +		bond->dev->header_ops = NULL;
>   		call_netdevice_notifiers(NETDEV_CHANGEADDR, bond->dev);
>   		call_netdevice_notifiers(NETDEV_RELEASE, bond->dev);
>   	}