From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Thomas Graf <tgraf@suug•ch>
Cc: jiri@resnulli•us, sfeldma@gmail•com, jhs@mojatatu•com,
bcrl@kvack•org, john.fastabend@gmail•com,
stephen@networkplumber•org, linville@tuxdriver•com,
nhorman@tuxdriver•com, nicolas.dichtel@6wind•com,
vyasevic@redhat•com, f.fainelli@gmail•com,
buytenh@wantstofly•org, aviadr@mellanox•com,
netdev@vger•kernel.org, davem@davemloft•net,
Shrijeet Mukherjee <shm@cumulusnetworks•com>,
gospo@cumulusnetworks•com
Subject: Re: [RFC PATCH 1/4] rtnetlink: new flag NLM_F_HW_OFFLOAD to indicate kernel object offload to hardware
Date: Fri, 21 Nov 2014 16:10:15 -0800 [thread overview]
Message-ID: <546FD467.5030602@cumulusnetworks.com> (raw)
In-Reply-To: <20141121231234.GA20810@casper.infradead.org>
On 11/21/14, 3:12 PM, Thomas Graf wrote:
> On 11/21/14 at 02:49pm, roopa@cumulusnetworks•com wrote:
>> diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h
>> index 1a85940..f78522d 100644
>> --- a/include/uapi/linux/netlink.h
>> +++ b/include/uapi/linux/netlink.h
>> @@ -54,6 +54,8 @@ struct nlmsghdr {
>> #define NLM_F_ACK 4 /* Reply with ack, with zero or error code */
>> #define NLM_F_ECHO 8 /* Echo this request */
>> #define NLM_F_DUMP_INTR 16 /* Dump was inconsistent due to sequence change */
>> ++#define NLM_F_KERNEL 32 /* This msg is only for the kernel */
>> +#define NLM_F_HW_OFFLOAD 64 /* offload this msg to hw */
>>
>> /* Modifiers to GET request */
>> #define NLM_F_ROOT 0x100 /* specify tree root */
> The NLM_F_ flag space applies to all Netlink messages including non
> networking bits and is reserved for flags vital to the functioning
> of the Netlink protocol itself. I suggest you move this to a
> RTNETLINK specific flags space.
I did try to add it at a layer lower than the netlink header. But,
nothing else fits so well as this :).
I did not find a place where i could make it a global flag for just
networking objects. As I mention in my patch description,
If not here it will be a per subsystem flag/attribute. I can post a
patch showing that approach as well.
Thanks!.
next prev parent reply other threads:[~2014-11-22 0:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 22:49 [RFC PATCH 1/4] rtnetlink: new flag NLM_F_HW_OFFLOAD to indicate kernel object offload to hardware roopa
2014-11-21 23:12 ` Thomas Graf
2014-11-22 0:10 ` Roopa Prabhu [this message]
2014-11-22 12:29 ` Thomas Graf
2014-11-22 19:37 ` Roopa Prabhu
2014-11-22 22:03 ` Vincent JARDIN
2014-11-22 20:08 ` Sergei Shtylyov
2014-11-23 15:00 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546FD467.5030602@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=aviadr@mellanox$(echo .)com \
--cc=bcrl@kvack$(echo .)org \
--cc=buytenh@wantstofly$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox