From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Jiri Pirko <jiri@resnulli•us>, netdev@vger•kernel.org
Cc: davem@davemloft•net
Subject: Re: [patch net-next] tc_vlan: fix type of tcfv_push_vid
Date: Mon, 24 Nov 2014 08:25:52 -0500 [thread overview]
Message-ID: <547331E0.6030305@mojatatu.com> (raw)
In-Reply-To: <1416825026-4628-1-git-send-email-jiri@resnulli.us>
On 11/24/14 05:30, Jiri Pirko wrote:
> Should be u16. So fix it to kill the sparse warning.
>
> Fixes: c7e2b9689ef8136 "sched: introduce vlan action"
> Signed-off-by: Jiri Pirko <jiri@resnulli•us>
> ---
> include/net/tc_act/tc_vlan.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/tc_act/tc_vlan.h b/include/net/tc_act/tc_vlan.h
> index c809c1d..93b70ad 100644
> --- a/include/net/tc_act/tc_vlan.h
> +++ b/include/net/tc_act/tc_vlan.h
> @@ -18,7 +18,7 @@
> struct tcf_vlan {
> struct tcf_common common;
> int tcfv_action;
> - __be16 tcfv_push_vid;
> + u16 tcfv_push_vid;
> __be16 tcfv_push_proto;
User space sends you this in be, no? I thought it was fine
the way it is. Isnt __be16 just an annotation?
cheers,
jamal
next prev parent reply other threads:[~2014-11-24 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 10:30 [patch net-next] tc_vlan: fix type of tcfv_push_vid Jiri Pirko
2014-11-24 13:25 ` Jamal Hadi Salim [this message]
2014-11-24 13:33 ` Jiri Pirko
2014-11-24 21:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547331E0.6030305@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox