Subject: Re: [PATCH v2] Add support of Cavium Liquidio ethernet adapters

From: Florian Fainelli <[email-masked]>
Date: Mon, 24 Nov 2014 13:01:06 -0800

On 11/23/2014 07:19 PM, Raghu Vatsavayi wrote:
> +if LIQUIDIO
> +
> +config LIQUIDIO_NAPI
> +	bool "Enable NAPI for LiquidIO"
> +	default y
> +	---help---
> +	  NAPI is a new driver API designed to reduce CPU and interrupt load
> +	  when the driver is receiving lots of packets from the card. You
> +	  would only disable this feature in very specific instances, like
> +	  an application that very rapidly sets up and tears down connections.
> +
> +	  If in doubt, say Y.

You probably do not want to offer a non-NAPI variant, pretty much all
drivers have NAPI built-in now.

> +
> +config LIQUIDIO_DEBUG
> +	int "Debug level for LiquidIO"
> +	range 0 4
> +	default 0
> +	---help---
> +	  Enables more extensive debug output. This may negatively
> +	  affect performance, so use values > 0 with caution.
> +	  0 disables extra debug
> +	  1 enables general messages
> +	  2 enables register access messages
> +	  3 enables debug messages
> +	  4 enables flow messages
> +
> +	  If in doubt, say 0.

This should be moved to dynamic_debug/ethtools' msglvl control knob.
--
Florian