From: Jonathan Toppins <jtoppins@cumulusnetworks•com>
To: Stephen Hemminger <stephen@networkplumber•org>,
roopa@cumulusnetworks•com
Cc: vyasevich@gmail•com, netdev@vger•kernel.org,
wkok@cumulusnetworks•com, gospo@cumulusnetworks•com,
sashok@cumulusnetworks•com
Subject: Re: [PATCH net-next] bridge: add vlan id to mdb notifications
Date: Wed, 26 Nov 2014 14:40:35 -0500 [thread overview]
Message-ID: <54762CB3.4090101@cumulusnetworks.com> (raw)
In-Reply-To: <20141126105614.6a42d697@urahara>
On 11/26/14 1:56 PM, Stephen Hemminger wrote:
> On Wed, 26 Nov 2014 05:53:33 -0800
> roopa@cumulusnetworks•com wrote:
>
>> diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h
>> index da17e45..db061fd 100644
>> --- a/include/uapi/linux/if_bridge.h
>> +++ b/include/uapi/linux/if_bridge.h
>> @@ -185,6 +185,7 @@ struct br_mdb_entry {
>> struct in6_addr ip6;
>> } u;
>> __be16 proto;
>> + __be16 vid;
>> } addr;
>> };
>>
>
> You can't add fields to existing binary API
>
Roopa, maybe a description of what use case this is trying to solve
would better justify the addition to the UAPI?
-Jon
next prev parent reply other threads:[~2014-11-26 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 13:53 [PATCH net-next] bridge: add vlan id to mdb notifications roopa
2014-11-26 18:56 ` Stephen Hemminger
2014-11-26 19:40 ` Jonathan Toppins [this message]
2014-11-26 20:45 ` Roopa Prabhu
2014-11-26 20:40 ` Roopa Prabhu
2014-11-26 21:53 ` Thomas Graf
2014-11-28 10:18 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54762CB3.4090101@cumulusnetworks.com \
--to=jtoppins@cumulusnetworks$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=sashok@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=vyasevich@gmail$(echo .)com \
--cc=wkok@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox