Subject: Re: [patch net-next v4 09/21] bridge: call netdev_sw_port_stp_update when bridge port STP status changes

From: Jamal Hadi Salim <[email-masked]>
Date: Thu, 27 Nov 2014 08:14:20 -0500

On 11/27/14 05:40, Jiri Pirko wrote:
> From: Scott Feldman <[email-masked]>
>
> To notify switch driver of change in STP state of bridge port, add new
> .ndo op and provide switchdev wrapper func to call ndo op. Use it in bridge
> code then.
>

As it stands right now we are going to pollute the ndo ops and grow
it fatter like the skb (its probably as fat).
If i am not mistaken ethtool has some scheme it uses to pass opaque
objects to different functions. Having a generic
set/get_netdev_offload_attr() would be the right thing to do.
An {id, *value} or {id, len, *value} or a void * would do.
So not objecting - but not ACKing either.

cheers,
jamal