Subject: Re: [PATCH net] bond: Check length of IFLA_BOND_ARP_IP_TARGET attributes

From: John Fastabend <[email-masked]>
Date: Sat, 29 Nov 2014 09:53:27 -0800

On 11/26/2014 03:22 PM, Thomas Graf wrote:
> Fixes: 7f28fa10 ("bonding: add arp_ip_target netlink support")
> Reported-by: John Fastabend <[email-masked]>
> Cc: Scott Feldman <[email-masked]>
> Signed-off-by: Thomas Graf <[email-masked]>
> ---
>   drivers/net/bonding/bond_netlink.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>

Looks good thanks! For what its worth...

Acked-by: John Fastabend <[email-masked]>

> diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
> index c13d83e..45f09a6 100644
> --- a/drivers/net/bonding/bond_netlink.c
> +++ b/drivers/net/bonding/bond_netlink.c
> @@ -225,7 +225,12 @@ static int bond_changelink(struct net_device *bond_dev,
>
>   		bond_option_arp_ip_targets_clear(bond);
>   		nla_for_each_nested(attr, data[IFLA_BOND_ARP_IP_TARGET], rem) {
> -			__be32 target = nla_get_be32(attr);
> +			__be32 target;
> +
> +			if (nla_len(attr) < sizeof(target))
> +				return -EINVAL;
> +
> +			target = nla_get_be32(attr);
>
>   			bond_opt_initval(&newval, (__force u64)target);
>   			err = __bond_opt_set(bond, BOND_OPT_ARP_TARGETS,
>

-- 
John Fastabend         Intel Corporation