From: Shuah Khan <shuahkh@osg•samsung.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi•com>
Cc: gregkh@linuxfoundation•org, akpm@linux-foundation•org,
mmarek@suse•cz, davem@davemloft•net, keescook@chromium•org,
tranmanphong@gmail•com, dh.herrmann@gmail•com, hughd@google•com,
bobby.prani@gmail•com, ebiederm@xmission•com,
serge.hallyn@ubuntu•com, linux-kbuild@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-api@vger•kernel.org,
netdev@vger•kernel.org,
"yrl.pp-manager.tt@hitachi•com" <yrl.pp-manager.tt@hitachi•com>,
Shuah Khan <shuahkh@osg•samsung.com>
Subject: Re: [PATCH v2 11/19] selftests/memory-hotplug: add install target to enable installing test
Date: Mon, 01 Dec 2014 09:12:23 -0700 [thread overview]
Message-ID: <547C9367.2070804@osg.samsung.com> (raw)
In-Reply-To: <5476BB87.6010808@hitachi.com>
On 11/26/2014 10:49 PM, Masami Hiramatsu wrote:
> (2014/11/12 5:27), Shuah Khan wrote:
>> Add a new make target to enable installing test. This target
>> installs test in the kselftest install location and add to the
>> kselftest script to run the test. Install target can be run
>> only from top level source dir.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg•samsung.com>
>> ---
>> tools/testing/selftests/memory-hotplug/Makefile | 17 +-
>> .../selftests/memory-hotplug/mem-on-off-test.sh | 238 +++++++++++++++++++++
>> .../selftests/memory-hotplug/on-off-test.sh | 238 ---------------------
>> 3 files changed, 253 insertions(+), 240 deletions(-)
>> create mode 100644 tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
>> delete mode 100644 tools/testing/selftests/memory-hotplug/on-off-test.sh
>>
>> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
>> index d46b8d4..8921631 100644
>> --- a/tools/testing/selftests/memory-hotplug/Makefile
>> +++ b/tools/testing/selftests/memory-hotplug/Makefile
>> @@ -1,9 +1,22 @@
>> +TEST_STR=/bin/bash ./mem-on-off-test.sh -r 2 || echo memory-hotplug selftests: [FAIL]
>> +
>> all:
>>
>> +install:
>> +ifdef INSTALL_KSFT_PATH
>> + install ./mem-on-off-test.sh $(INSTALL_KSFT_PATH)/mem-on-off-test.sh
>> + @echo echo Start memory hotplug test .... >> $(KSELFTEST)
>> + @echo "$(TEST_STR)" >> $(KSELFTEST) >> $(KSELFTEST)
>> + @echo echo End memory hotplug test .... >> $(KSELFTEST)
>> + @echo echo ============================== >> $(KSELFTEST)
>> +else
>> + @echo Run make kselftest_install in top level source directory
>> +endif
>
> I saw this pattern repeated many times in this series.
> Can we make it a macro and include it instead of repeating this code?
>
I might be able to move this to the selftest Makfile and use target as the
string. I will play with it and see if I can reduce the duplication further.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@osg•samsung.com | (970) 217-8978
next prev parent reply other threads:[~2014-12-01 16:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 20:27 [PATCH v2 00/19] kselftest install target feature Shuah Khan
2014-11-11 20:27 ` [PATCH v2 01/19] selftests/user: move test out of Makefile into a shell script Shuah Khan
2014-11-11 20:27 ` [PATCH v2 02/19] kbuild: kselftest_install - add a new make target to install selftests Shuah Khan
2014-11-19 15:59 ` Shuah Khan
2014-11-27 5:32 ` Masami Hiramatsu
2014-12-01 16:27 ` Shuah Khan
[not found] ` <a2344d4df903d673afe1631118f40917f773cc9a.1415735831.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-12-01 15:47 ` Michal Marek
2014-12-01 16:39 ` Shuah Khan
2014-12-03 12:09 ` Michal Marek
2014-12-03 14:14 ` Shuah Khan
2014-11-11 20:27 ` [PATCH v2 03/19] selftests: add install target to enable installing selftests Shuah Khan
2014-11-27 5:45 ` Masami Hiramatsu
2014-12-01 16:16 ` Shuah Khan
2014-11-11 20:27 ` [PATCH v2 04/19] selftests/breakpoints: add install target to enable installing test Shuah Khan
2014-11-11 20:27 ` [PATCH v2 05/19] selftests/cpu-hotplug: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 06/19] selftests/efivarfs: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 07/19] selftests/firmware: " Shuah Khan
[not found] ` <1d2d13556ddbbbbb13989cdcb08447909bc4afaf.1415735831.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-11-11 21:29 ` Kees Cook
2014-11-12 1:06 ` Shuah Khan
[not found] ` <5462B2A3.9000007-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-11-19 16:13 ` Shuah Khan
2014-11-11 20:27 ` [PATCH v2 08/19] selftests/ipc: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 09/19] selftests/kcmp: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 10/19] selftests/memfd: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 11/19] selftests/memory-hotplug: " Shuah Khan
2014-11-27 5:49 ` Masami Hiramatsu
2014-12-01 16:12 ` Shuah Khan [this message]
2014-11-11 20:27 ` [PATCH v2 12/19] selftests/mount: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 13/19] selftests/mqueue: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 14/19] selftests/net: " Shuah Khan
[not found] ` <cover.1415735831.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-11-11 20:27 ` [PATCH v2 15/19] selftests/ptrace: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 16/19] selftests/sysctl: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 17/19] selftests/timers: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 18/19] selftests/vm: " Shuah Khan
2014-11-11 20:27 ` [PATCH v2 19/19] selftests/user: " Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C9367.2070804@osg.samsung.com \
--to=shuahkh@osg$(echo .)samsung.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bobby.prani@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dh.herrmann@gmail$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hughd@google$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=masami.hiramatsu.pt@hitachi$(echo .)com \
--cc=mmarek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=serge.hallyn@ubuntu$(echo .)com \
--cc=tranmanphong@gmail$(echo .)com \
--cc=yrl.pp-manager.tt@hitachi$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox