Subject: Re: [patch net-next 4/6] net_sched: cls_flow: remove faulty use of list_for_each_entry_rcu

From: Jamal Hadi Salim <[email-masked]>
Date: Wed, 03 Dec 2014 08:02:17 -0500

On 12/02/14 12:00, Jiri Pirko wrote:
> rcu variant is not correct here. The code is called by updater (rtnl
> lock is held), not by reader (no rcu_read_lock is held).
>
> Signed-off-by: Jiri Pirko <[email-masked]>

Same comment as other one..
I actually i am not so sure about the get_ either.
The core may end up invoking that first before doing a del
so for consistency we need rcu version.

cheers,
jamal