From: John Fastabend <john.fastabend@gmail•com>
To: Scott Feldman <sfeldma@gmail•com>
Cc: "Jianhua Xie" <jianhua.xie@freescale•com>,
"Roopa Prabhu" <roopa@cumulusnetworks•com>,
"Jiří Pírko" <jiri@resnulli•us>,
"Jamal Hadi Salim" <jhs@mojatatu•com>,
"Benjamin LaHaise" <bcrl@kvack•org>,
"Thomas Graf" <tgraf@suug•ch>,
"stephen@networkplumber•org" <stephen@networkplumber•org>,
"John Linville" <linville@tuxdriver•com>,
"nhorman@tuxdriver•com" <nhorman@tuxdriver•com>,
"Nicolas Dichtel" <nicolas.dichtel@6wind•com>,
"vyasevic@redhat•com" <vyasevic@redhat•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"buytenh@wantstofly•org" <buytenh@wantstofly•org>,
"Aviad Raveh" <aviadr@mellanox•com>,
Netdev <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
shm@cumulusnetworks•com,
"Andy Gospodarek" <gospo@cumulusnetworks•com>
Subject: Re: [PATCH 3/3] rocker: set feature NETIF_F_HW_SWITCH_OFFLOAD
Date: Thu, 04 Dec 2014 22:38:56 -0800 [thread overview]
Message-ID: <54815300.2050600@gmail.com> (raw)
In-Reply-To: <CAE4R7bDCcE94WQE50J+suAr9F=OFvQnC73txA+xrC2JxMseYkw@mail.gmail.com>
On 12/04/2014 10:16 PM, Scott Feldman wrote:
> On Thu, Dec 4, 2014 at 7:25 PM, Jianhua Xie <jianhua.xie@freescale•com> wrote:
>>
>> 在 2014年12月05日 10:26, roopa@cumulusnetworks•com 写道:
>>
>>> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>>>
>>> This patch just sets the feature flag on rocker ports
>>> ---
>>> drivers/net/ethernet/rocker/rocker.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/rocker/rocker.c
>>> b/drivers/net/ethernet/rocker/rocker.c
>>> index fded127..3fe19b0 100644
>>> --- a/drivers/net/ethernet/rocker/rocker.c
>>> +++ b/drivers/net/ethernet/rocker/rocker.c
>>> @@ -4003,7 +4003,8 @@ static int rocker_probe_port(struct rocker *rocker,
>>> unsigned int port_number)
>>> NAPI_POLL_WEIGHT);
>>> rocker_carrier_init(rocker_port);
>>> - dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
>>> + dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER |
>>> + NETIF_F_HW_SWITCH_OFFLOAD;
>>
>> Do you have a plan on enabling/disabling this flag dynamically by ethtool?
>
> Might get it for free if we recycle NETIF_F_HW_L2FW_DOFFLOAD;
> NETIF_F_HW_L2FW_DOFFLOAD seems to be supported by ethtool already.
See my other note but ethtool support for feature flags makes
this pretty close to trivial to implement these days.
Take a look @ netdev_features_strings.
>
>>
>> Thanks & B.R
>> Jianhua
>>
>>> err = register_netdev(dev);
>>> if (err) {
>>
>>
--
John Fastabend Intel Corporation
next prev parent reply other threads:[~2014-12-05 6:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 2:26 [PATCH 3/3] rocker: set feature NETIF_F_HW_SWITCH_OFFLOAD roopa
2014-12-05 3:25 ` Jianhua Xie
2014-12-05 4:14 ` Roopa Prabhu
2014-12-05 4:44 ` Jianhua Xie
2014-12-05 6:16 ` Scott Feldman
2014-12-05 6:38 ` John Fastabend [this message]
2014-12-05 13:18 ` Sergei Shtylyov
2014-12-05 14:04 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54815300.2050600@gmail.com \
--to=john.fastabend@gmail$(echo .)com \
--cc=aviadr@mellanox$(echo .)com \
--cc=bcrl@kvack$(echo .)org \
--cc=buytenh@wantstofly$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jianhua.xie@freescale$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox