From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Scott Feldman <sfeldma@gmail•com>
Cc: "Jiří Pírko" <jiri@resnulli•us>,
"Jamal Hadi Salim" <jhs@mojatatu•com>,
"Benjamin LaHaise" <bcrl@kvack•org>,
"Thomas Graf" <tgraf@suug•ch>,
"john fastabend" <john.fastabend@gmail•com>,
"stephen@networkplumber•org" <stephen@networkplumber•org>,
"John Linville" <linville@tuxdriver•com>,
"nhorman@tuxdriver•com" <nhorman@tuxdriver•com>,
"Nicolas Dichtel" <nicolas.dichtel@6wind•com>,
"vyasevic@redhat•com" <vyasevic@redhat•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"buytenh@wantstofly•org" <buytenh@wantstofly•org>,
"Aviad Raveh" <aviadr@mellanox•com>,
Netdev <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
shm@cumulusnetworks•com,
"Andy Gospodarek" <gospo@cumulusnetworks•com>
Subject: Re: [PATCH iproute2] bridge link: add option 'self'
Date: Thu, 04 Dec 2014 23:04:25 -0800 [thread overview]
Message-ID: <548158F9.5080903@cumulusnetworks.com> (raw)
In-Reply-To: <CAE4R7bA3JSyHxe5ptVzpCzP5nHmKm8KyPqGvK7a_N2TWX-BNRw@mail.gmail.com>
On 12/4/14, 10:52 PM, Scott Feldman wrote:
> On Thu, Dec 4, 2014 at 6:27 PM, <roopa@cumulusnetworks•com> wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>>
>> Currently self is set internally only if hwmode is set.
>> This makes it necessary for the hw to have a mode.
>> There is no hwmode really required to go to hardware. So, introduce
>> self for anybody who wants to target hardware.
> Can you include unwinding the hwmode 'swdev' setting for
> kernel/iproute2 in v2? With this "self" option, and your new
> NETIF_F_HW_SWITCH_OFFLOAD flag, we don't need the hwmde 'swdev'.
yep. will do. thanks
>> ---
>> bridge/link.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/bridge/link.c b/bridge/link.c
>> index 90d9e7f..2b86141 100644
>> --- a/bridge/link.c
>> +++ b/bridge/link.c
>> @@ -321,6 +321,9 @@ static int brlink_modify(int argc, char **argv)
>> "\"veb\".\n");
>> exit(-1);
>> }
>> + } else if (strcmp(*argv, "self") == 0) {
>> + NEXT_ARG();
>> + flags = BRIDGE_FLAGS_SELF;
>> } else {
>> usage();
>> }
>> --
>> 1.7.10.4
>>
next prev parent reply other threads:[~2014-12-05 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 2:27 [PATCH iproute2] bridge link: add option 'self' roopa
2014-12-05 6:52 ` Scott Feldman
2014-12-05 7:04 ` Roopa Prabhu [this message]
2014-12-05 7:55 ` Jiri Pirko
2014-12-05 13:46 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548158F9.5080903@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=aviadr@mellanox$(echo .)com \
--cc=bcrl@kvack$(echo .)org \
--cc=buytenh@wantstofly$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox