From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Thomas Graf <tgraf@suug•ch>
Cc: jiri@resnulli•us, sfeldma@gmail•com, jhs@mojatatu•com,
bcrl@kvack•org, john.fastabend@gmail•com,
stephen@networkplumber•org, linville@tuxdriver•com,
vyasevic@redhat•com, netdev@vger•kernel.org, davem@davemloft•net,
shm@cumulusnetworks•com, gospo@cumulusnetworks•com
Subject: Re: [PATCH net-next v3 2/2] rocker: remove swdev mode
Date: Sun, 07 Dec 2014 08:55:54 -0800 [thread overview]
Message-ID: <5484869A.6020204@cumulusnetworks.com> (raw)
In-Reply-To: <20141207081928.GA2215@casper.infradead.org>
On 12/7/14, 12:19 AM, Thomas Graf wrote:
> On 12/06/14 at 10:54pm, roopa@cumulusnetworks•com wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks•com>
>> ---
>> drivers/net/ethernet/rocker/rocker.c | 18 +-----------------
>> include/linux/rtnetlink.h | 2 +-
>> net/core/rtnetlink.c | 12 +++++++++---
>> 3 files changed, 11 insertions(+), 21 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
>> index fded127..9f1d256 100644
>> --- a/drivers/net/ethernet/rocker/rocker.c
>> +++ b/drivers/net/ethernet/rocker/rocker.c
>> @@ -3755,7 +3739,7 @@ static int rocker_port_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
>> u32 filter_mask)
>> {
>> struct rocker_port *rocker_port = netdev_priv(dev);
>> - u16 mode = BRIDGE_MODE_SWDEV;
>> + u16 mode = -1;
> ^^^
>
> I assume you meant s16
>
yes :(...i thought i had covered all places....missed this
one...resubmitting ..
next prev parent reply other threads:[~2014-12-07 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 6:54 [PATCH net-next v3 2/2] rocker: remove swdev mode roopa
2014-12-07 8:19 ` Thomas Graf
2014-12-07 16:55 ` Roopa Prabhu [this message]
2014-12-08 11:03 ` Jiri Pirko
2014-12-08 11:41 ` Daniel Borkmann
2014-12-08 16:18 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5484869A.6020204@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=bcrl@kvack$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox