Subject: Re: [PATCH v2] sh_eth: Optimization for RX excess judgement

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 08 Dec 2014 14:47:25 +0300

Hello.

On 12/8/2014 1:48 PM, Yoshihiro Kaneko wrote:

> From: Mitsuhiro Kimura <[email-masked]>

> Both of 'boguscnt' and 'quota' have nearly meaning as the condition of
> the reception loop.
> In order to cut down redundant processing, this patch changes excess
> judgement.

> Signed-off-by: Mitsuhiro Kimura <[email-masked]>
> Signed-off-by: Yoshihiro Kaneko <[email-masked]>
> ---

> This patch is based on net-next tree.

> v2 [Yoshihiro Kaneko]
> * re-spin for net-next.
> * remove unneeded check of "quota".

    This is not a complete list. :-/

>   drivers/net/ethernet/renesas/sh_eth.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index dbe8606..266c9b2 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
[...]
> @@ -1501,6 +1499,8 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status, int *quota)
>   		sh_eth_write(ndev, EDRRR_R, EDRRR);
>   	}
>
> +	*quota -= limit - boguscnt + 1;
> +

    Sorry for the wrong previous suggestion, it clearly should have been -1, 
not +1. :-<

[...]

WBR, Sergei