From: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, bridge@lists•linux-foundation.org
Subject: Re: [PATCH net-next] bridge: Add ability to always enable TSO/UFO
Date: Thu, 11 Dec 2014 11:04:44 +0900 [thread overview]
Message-ID: <5488FBBC.2050105@lab.ntt.co.jp> (raw)
In-Reply-To: <20141210.145047.1148744559031706340.davem@davemloft.net>
On 2014/12/11 4:50, David Miller wrote:
> From: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
> Date: Wed, 10 Dec 2014 11:43:14 +0900
>
>> - features &= ~NETIF_F_ONE_FOR_ALL;
>> + features &= ~NETIF_F_ONE_FOR_ALL | NETIF_F_GSO_SOFTWARE;
>
> I don't think this is the expression you intend to use.
Thank you, but this is really my intended expression.
"features &= ~NETIF_F_ONE_FOR_ALL" drops all of ONE_FOR_ALL bits
including GSO_SOFTWARE.
But I want to leave GSO_SOFTWARE bits here.
>
> I think you meant:
>
> features &= ~(NETIF_F_ONE_FOR_ALL | NETIF_F_GSO_SOFTWARE);
ONE_FOR_ALL already includes GSO_SOFTWARE.
>
> Or:
>
> features = ~NETIF_F_ONE_FOR_ALL;
> features |= NETIF_F_GSO_SOFTWARE;
This way, users cannot drop TSO/UFO by ethtool.
Thanks,
Toshiaki Makita
next prev parent reply other threads:[~2014-12-11 2:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 2:43 [PATCH net-next] vlan: Add ability to always enable TSO/UFO Toshiaki Makita
2014-12-10 2:43 ` [PATCH net-next] bridge: " Toshiaki Makita
2014-12-10 19:50 ` David Miller
2014-12-11 2:04 ` Toshiaki Makita [this message]
2014-12-11 2:13 ` David Miller
2014-12-11 2:20 ` Toshiaki Makita
2014-12-12 16:01 ` [PATCH net-next] vlan: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5488FBBC.2050105@lab.ntt.co.jp \
--to=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox