public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Amir Vadai <amirv@mellanox•com>
To: Wei Yang <weiyang@linux•vnet.ibm.com>,
	David Miller <davem@davemloft•net>,
	"David.Laight@ACULAB•COM" <David.Laight@ACULAB•COM>
Cc: "eric.dumazet@gmail•com" <eric.dumazet@gmail•com>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	Gideon Naim <gideonn@mellanox•com>,
	"edumazet@google•com" <edumazet@google•com>
Subject: Re: [PATCH net] net/mlx4_en: correct the endianness of doorbell_qpn on big endian platform
Date: Mon, 15 Dec 2014 11:59:15 +0200	[thread overview]
Message-ID: <548EB0F3.4050802@mellanox.com> (raw)
In-Reply-To: <20141215013249.GA7341@richard>

On 12/15/2014 3:32 AM, Wei Yang wrote:
[...]

Hi David's,

I need to do a native endianness write to the NIC register (the write is
on the fast path and the register value could be calculated once).

iowrite32be() is calling cpu_to_be32() on the value.
iowrite32() is calling cpu_to_le32().

I thought about using raw_writel() but as David Miller said, it lacks
necessary io barriers on some archs.

Does the only solution to this, is to add some sort of
iowrite32be_native(__be32 val,...) function to all the archs?

Thanks,
Amir

next prev parent reply	other threads:[~2014-12-15  9:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30  2:43 [PATCH net] net/mlx4_en: correct the endianness of doorbell_qpn on big endian platform Wei Yang
2014-11-30  2:52 ` Wei Yang
2014-11-30 19:27 ` Eric Dumazet
2014-12-01  1:29   ` Wei Yang
2014-12-06  5:31 ` David Miller
2014-12-06  5:46   ` Eric Dumazet
2014-12-08  3:12     ` Wei Yang
2014-12-08 10:00     ` David Laight
2014-12-08 14:42       ` Wei Yang
2014-12-13  3:13         ` Wei Yang
2014-12-14  4:43           ` David Miller
2014-12-15  1:32             ` Wei Yang
2014-12-15  9:59               ` Amir Vadai [this message]
2014-12-15 10:00               ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548EB0F3.4050802@mellanox.com \
    --to=amirv@mellanox$(echo .)com \
    --cc=David.Laight@ACULAB$(echo .)COM \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=gideonn@mellanox$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=weiyang@linux$(echo .)vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox